Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docker] Custom docker container for Caddy proxy #6920

Closed
SchrodingersGat opened this issue Apr 2, 2024 · 9 comments
Closed

[Docker] Custom docker container for Caddy proxy #6920

SchrodingersGat opened this issue Apr 2, 2024 · 9 comments
Labels
docker Docker / docker-compose enhancement This is an suggested enhancement or new feature setup Relates to the InvenTree setup / installation process
Milestone

Comments

@SchrodingersGat
Copy link
Member

Currently the docker setup requires a custom caddy config file which must be copied into the running caddy container.

However we could simplify this by building our own proxy container which we then push to dockerhub / ghcr

This would reduce the number of required files

@SchrodingersGat SchrodingersGat added enhancement This is an suggested enhancement or new feature docker Docker / docker-compose setup Relates to the InvenTree setup / installation process labels Apr 2, 2024
@SchrodingersGat SchrodingersGat added this to the horizon milestone Apr 2, 2024
@SchrodingersGat SchrodingersGat modified the milestones: horizon, 1.0.0 Nov 20, 2024
@SchrodingersGat
Copy link
Member Author

While a custom caddyfile container might make complex / custom deployments harder, users can always revert to their own custom container in such cases. In general this should make setup simpler. A good target for 1.0.0

@matmair
Copy link
Member

matmair commented Nov 20, 2024

@SchrodingersGat maybe we can use a shared folder between server and proxy and make the config available that way?

@wolflu05
Copy link
Contributor

That will only work with named volumes, but then we need to instruct people to not change that named volume to a bind mount, but people will do that, ...

@matmair
Copy link
Member

matmair commented Nov 20, 2024

Wouldn’t the server not work anymore at that point?

@SchrodingersGat
Copy link
Member Author

@wolflu05
Copy link
Contributor

Wouldn’t the server not work anymore at that point?

I do not really understand what you mean by this.

@SchrodingersGat
Copy link
Member Author

Image is now live - https://hub.docker.com/r/inventree/inventree-caddy/tags

I am currently testing , and will push a simplified docker setup if it works well

@SchrodingersGat
Copy link
Member Author

#8538

@SchrodingersGat
Copy link
Member Author

Closing, see #8538

@SchrodingersGat SchrodingersGat closed this as not planned Won't fix, can't repro, duplicate, stale Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Docker / docker-compose enhancement This is an suggested enhancement or new feature setup Relates to the InvenTree setup / installation process
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants