Skip to content

Small typescript cleanups #13508

Small typescript cleanups

Small typescript cleanups #13508

Triggered via pull request July 18, 2024 21:43
Status Success
Total duration 16m 38s
Artifacts 1

qc_checks.yaml

on: pull_request
Build - UI Platform
1m 53s
Build - UI Platform
Style [pre-commit]
35s
Style [pre-commit]
Tests - API Schema Documentation
0s
Tests - API Schema Documentation
Style [Documentation]
32s
Style [Documentation]
Tests - Migrations [PostgreSQL]
0s
Tests - Migrations [PostgreSQL]
Tests - Full Migration [SQLite]
0s
Tests - Full Migration [SQLite]
Tests - inventree-python
0s
Tests - inventree-python
Tests - DB [PostgreSQL]
0s
Tests - DB [PostgreSQL]
Tests - DB [MySQL]
0s
Tests - DB [MySQL]
Tests - Platform UI
15m 36s
Tests - Platform UI
Matrix: coverage
Style - Classic UI [JS]
1m 26s
Style - Classic UI [JS]
Push new schema
0s
Push new schema
Fit to window
Zoom out
Zoom in

Annotations

8 errors, 8 warnings, and 1 notice
[chromium] › pages/pui_scan.spec.ts:90:1 › PUI - Pages - Index - Scan (General): src/frontend/tests/baseFixtures.ts#L79
1) [chromium] › pages/pui_scan.spec.ts:90:1 › PUI - Pages - Index - Scan (General) ─────────────── Error: expect(received).toEqual(expected) // deep equality - Expected - 1 + Received + 41 - Array [] + Array [ + ConsoleMessage { + "_event": Object { + "args": Array [], + "location": Object { + "columnNumber": 0, + "lineNumber": 0, + "url": "http://localhost:8000/api/settings/global/", + }, + "page": EventEmitter { + "_events": Object { + "bindingCall": [Function anonymous], + "close": [Function anonymous], + "crash": [Function anonymous], + "download": [Function anonymous], + "fileChooser": [Function anonymous], + "frameAttached": [Function anonymous], + "frameDetached": [Function anonymous], + "locatorHandlerTriggered": [Function anonymous], + "route": [Function anonymous], + "video": [Function anonymous], + "webSocket": [Function anonymous], + "worker": [Function anonymous], + }, + "_eventsCount": 12, + "_maxListeners": undefined, + "_object": Object { + "_guid": "page@fd0af904a2d067187bf62b50cf1ec3a2", + "_type": "Page", + }, + Symbol(kCapture): false, + }, + "text": "Failed to load resource: the server responded with a status of 401 (Unauthorized)", + "type": "error", + }, + "_page": Object { + "_guid": "page@fd0af904a2d067187bf62b50cf1ec3a2", + "_type": "Page", + }, + }, + ] at baseFixtures.ts:79 77 | }); 78 | await use(page); > 79 | expect(messages).toEqual([]); | ^ 80 | } 81 | }); 82 | at Object.page (/home/runner/work/InvenTree/InvenTree/src/frontend/tests/baseFixtures.ts:79:22)
[chromium] › pui_general.spec.ts:71:1 › PUI - Sales: src/frontend/tests/pui_general.spec.ts#L1
2) [chromium] › pui_general.spec.ts:71:1 › PUI - Sales ─────────────────────────────────────────── Test timeout of 90000ms exceeded.
[chromium] › pui_general.spec.ts:71:1 › PUI - Sales: src/frontend/tests/baseFixtures.ts#L79
2) [chromium] › pui_general.spec.ts:71:1 › PUI - Sales ─────────────────────────────────────────── Error: expect(received).toEqual(expected) // deep equality - Expected - 1 + Received + 353 - Array [] + Array [ + ConsoleMessage { + "_event": Object { + "args": Array [], + "location": Object { + "columnNumber": 0, + "lineNumber": 0, + "url": "http://localhost:8000/api/order/so/?customer_detail=true&customer=30", + }, + "page": EventEmitter { + "_events": Object { + "bindingCall": [Function anonymous], + "close": [Function anonymous], + "crash": [Function anonymous], + "download": [Function anonymous], + "fileChooser": [Function anonymous], + "frameAttached": [Function anonymous], + "frameDetached": [Function anonymous], + "locatorHandlerTriggered": [Function anonymous], + "route": [Function anonymous], + "video": [Function anonymous], + "webSocket": [Function anonymous], + "worker": [Function anonymous], + }, + "_eventsCount": 12, + "_maxListeners": undefined, + "_object": Object { + "_guid": "page@6c80e298f8dc66b90c24ce76aee7a16c", + "_type": "Page", + }, + Symbol(kCapture): false, + }, + "text": "Failed to load resource: the server responded with a status of 401 (Unauthorized)", + "type": "error", + }, + "_page": Object { + "_guid": "page@6c80e298f8dc66b90c24ce76aee7a16c", + "_type": "Page", + }, + }, + ConsoleMessage { + "_event": Object { + "args": Array [], + "location": Object { + "columnNumber": 0, + "lineNumber": 0, + "url": "http://localhost:8000/api/order/so/?customer_detail=true&customer=30&limit=25&offset=0", + }, + "page": EventEmitter { + "_events": Object { + "bindingCall": [Function anonymous], + "close": [Function anonymous], + "crash": [Function anonymous], + "download": [Function anonymous], + "fileChooser": [Function anonymous], + "frameAttached": [Function anonymous], + "frameDetached": [Function anonymous], + "locatorHandlerTriggered": [Function anonymous], + "route": [Function anonymous], + "video": [Function anonymous], + "webSocket": [Function anonymous], + "worker": [Function anonymous], + }, + "_eventsCount": 12, + "_maxListeners": undefined, + "_object": Object { + "_guid": "page@6c80e298f8dc66b90c24ce76aee7a16c", + "_type": "Page", + }, + Symbol(kCapture): false, + }, + "text": "Failed to load resource: the server responded with a status of 401 (Unauthorized)", + "type": "error", + }, + "_page": Object { + "_guid": "page@6c80e298f8dc66b90c24ce76aee7a16c", + "_type": "Page", + }, + }, + ConsoleMessage { + "_event": Object { + "args": Array [], + "location": Object { + "columnNumber": 0, + "lineNumber": 0, + "url": "http://localhost:8000/api/project-code/", + }, + "page": EventEmitter { + "_events": Object { + "bindingCall": [Function anonymous], + "close": [Function anonymous], + "crash": [Function anonymous], + "download": [Function anonymous], + "fileChooser": [Function anonymous], + "frameAttached": [Function anonymous], + "frameDetached": [Function anonymous], + "locator
[chromium] › pui_general.spec.ts:71:1 › PUI - Sales: src/frontend/tests/pui_general.spec.ts#L91
2) [chromium] › pui_general.spec.ts:71:1 › PUI - Sales ─────────────────────────────────────────── Error: locator.waitFor: Test timeout of 90000ms exceeded. Call log: - waiting for getByRole('cell', { name: 'Dorathy Gross' }) to be visible 89 | await page.getByRole('tab', { name: 'Sales Orders' }).click(); 90 | await page.getByRole('tab', { name: 'Contacts' }).click(); > 91 | await page.getByRole('cell', { name: 'Dorathy Gross' }).waitFor(); | ^ 92 | await page 93 | .getByRole('row', { name: 'Dorathy Gross [email protected]' }) 94 | .waitFor(); at /home/runner/work/InvenTree/InvenTree/src/frontend/tests/pui_general.spec.ts:91:59
[firefox] › pages/pui_part.spec.ts:127:1 › PUI - Pages - Part - Pricing (Internal): src/frontend/tests/baseFixtures.ts#L79
3) [firefox] › pages/pui_part.spec.ts:127:1 › PUI - Pages - Part - Pricing (Internal) ──────────── Error: expect(received).toEqual(expected) // deep equality - Expected - 1 + Received + 265 - Array [] + Array [ + ConsoleMessage { + "_event": Object { + "args": Array [ + EventEmitter { + "_events": Object { + "previewUpdated": [Function anonymous], + }, + "_eventsCount": 1, + "_maxListeners": undefined, + "_object": Object { + "_guid": "handle@df8422b17c59283cff4d04e3c3aa2e00", + "_type": "JSHandle", + }, + Symbol(kCapture): false, + }, + ], + "location": Object { + "columnNumber": 19, + "lineNumber": 2214, + "url": "http://localhost:5173/node_modules/.vite/deps/chunk-AGKALZCE.js?v=3c439c3a", + }, + "page": EventEmitter { + "_events": Object { + "bindingCall": [Function anonymous], + "close": [Function anonymous], + "crash": [Function anonymous], + "download": [Function anonymous], + "fileChooser": [Function anonymous], + "frameAttached": [Function anonymous], + "frameDetached": [Function anonymous], + "locatorHandlerTriggered": [Function anonymous], + "route": [Function anonymous], + "video": [Function anonymous], + "webSocket": [Function anonymous], + "worker": [Function anonymous], + }, + "_eventsCount": 12, + "_maxListeners": undefined, + "_object": Object { + "_guid": "page@eed6d3f6802b05adb7a286846e1b23a3", + "_type": "Page", + }, + Symbol(kCapture): false, + }, + "text": "The above error occurred in one of your React components: + + Lazy + Suspense + LoadingItem@http://localhost:5173/src/functions/loading.tsx:994:28 + div + _Box<@http://localhost:5173/node_modules/.vite/deps/chunk-AGKALZCE.js?v=3c439c3a:3434:3 + Container<@http://localhost:5173/node_modules/.vite/deps/chunk-AGKALZCE.js?v=3c439c3a:14767:25 + Resizable2@http://localhost:5173/node_modules/.vite/deps/react-grid-layout.js?v=350e0887:2527:39 + DraggableCore@http://localhost:5173/node_modules/.vite/deps/react-grid-layout.js?v=350e0887:1481:9 + GridItem@http://localhost:5173/node_modules/.vite/deps/react-grid-layout.js?v=350e0887:3059:9 + div + ReactGridLayout@http://localhost:5173/node_modules/.vite/deps/react-grid-layout.js?v=350e0887:3591:9 + ResponsiveReactGridLayout@http://localhost:5173/node_modules/.vite/deps/react-grid-layout.js?v=350e0887:4320:9 + WidthProvider@http://localhost:5173/node_modules/.vite/deps/react-grid-layout.js?v=350e0887:5074:11 + div + WidgetLayout@http://localhost:5173/src/components/widgets/WidgetLayout.tsx:2166:29 + Home@http://localhost:5173/src/pages/Index/Home.tsx:1114:49 + Suspense + RenderedRoute@http://localhost:5173/node_modules/.vite/deps/react-router-dom.js?v=137e2fb7:3992:7 + Outlet@http://localhost:5173/node_modules/.vite/deps/react-router-dom.js?v=137e2fb7:4359:20 + _ErrorBoundary@http://localhost:5173/node_modules/.vite/deps/@sentry_react.js?v=41ae517d:21962:5 + Boundary@http://localhost:5173/src/components/Boundary.tsx:999:25 + div + _Box<@http://localhost:5173/node_modules/.vite/deps/chunk-AGKALZCE.js?v=3c439c3a:3434:3 + Container<@http://localhost:5173/node_modules/.vite/deps/chunk-AGKALZCE.js?v=3c439c3a:14767:25 + div + _Box<@http://localhost:5173/node_modules/.vite/deps/chunk-AGKALZCE.js?v=3c439c3a:3434:3 + Flex<@http://localhost:5173/node_modules/.vite/deps/chunk-AGKALZCE.js?v=3c439c3a:9305:25 + ProtectedRoute@http://localhost:5173/src/components/nav/Layout.tsx:1341:31 + LayoutComponent@http://localhost:
[firefox] › pui_general.spec.ts:71:1 › PUI - Sales: src/frontend/tests/pui_general.spec.ts#L1
4) [firefox] › pui_general.spec.ts:71:1 › PUI - Sales ──────────────────────────────────────────── Test timeout of 90000ms exceeded.
[firefox] › pui_general.spec.ts:71:1 › PUI - Sales: src/frontend/tests/baseFixtures.ts#L79
4) [firefox] › pui_general.spec.ts:71:1 › PUI - Sales ──────────────────────────────────────────── Error: expect(received).toEqual(expected) // deep equality - Expected - 1 + Received + 54 - Array [] + Array [ + ConsoleMessage { + "_event": Object { + "args": Array [ + EventEmitter { + "_events": Object { + "previewUpdated": [Function anonymous], + }, + "_eventsCount": 1, + "_maxListeners": undefined, + "_object": Object { + "_guid": "handle@974e5de3769d24f94a19823fc6f3a872", + "_type": "JSHandle", + }, + Symbol(kCapture): false, + }, + ], + "location": Object { + "columnNumber": 19, + "lineNumber": 2214, + "url": "http://localhost:5173/node_modules/.vite/deps/chunk-AGKALZCE.js?v=3c439c3a", + }, + "page": EventEmitter { + "_events": Object { + "bindingCall": [Function anonymous], + "close": [Function anonymous], + "crash": [Function anonymous], + "download": [Function anonymous], + "fileChooser": [Function anonymous], + "frameAttached": [Function anonymous], + "frameDetached": [Function anonymous], + "locatorHandlerTriggered": [Function anonymous], + "route": [Function anonymous], + "video": [Function anonymous], + "webSocket": [Function anonymous], + "worker": [Function anonymous], + }, + "_eventsCount": 12, + "_maxListeners": undefined, + "_object": Object { + "_guid": "page@81c3f3e4c2294730c009cbe664e9cd5e", + "_type": "Page", + }, + Symbol(kCapture): false, + }, + "text": "Query data cannot be undefined. Please make sure to return a value other than undefined from your query function. Affected query key: [\"badge\",\"owner\",6]", + "type": "error", + }, + "_page": Object { + "_guid": "page@81c3f3e4c2294730c009cbe664e9cd5e", + "_type": "Page", + }, + }, + ] at baseFixtures.ts:79 77 | }); 78 | await use(page); > 79 | expect(messages).toEqual([]); | ^ 80 | } 81 | }); 82 | at Object.page (/home/runner/work/InvenTree/InvenTree/src/frontend/tests/baseFixtures.ts:79:22)
[firefox] › pui_general.spec.ts:71:1 › PUI - Sales: src/frontend/tests/pui_general.spec.ts#L114
4) [firefox] › pui_general.spec.ts:71:1 › PUI - Sales ──────────────────────────────────────────── Error: locator.click: Test timeout of 90000ms exceeded. Call log: - waiting for getByRole('link', { name: 'Customer A' }) 112 | 113 | // Return Order Details > 114 | await page.getByRole('link', { name: 'Customer A' }).click(); | ^ 115 | await page.getByRole('tab', { name: 'Return Orders' }).click(); 116 | await page.getByRole('cell', { name: 'RMA-' }).click(); 117 | await page.getByText('RMA-0001', { exact: true }).waitFor(); at /home/runner/work/InvenTree/InvenTree/src/frontend/tests/pui_general.spec.ts:114:56
Build - UI Platform
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/setup-node@1a4442cacd436585916779262731d5b162bc6ec7. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Style - Classic UI [JS]
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/setup-node@1a4442cacd436585916779262731d5b162bc6ec7. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Tests - Platform UI
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/setup-node@1a4442cacd436585916779262731d5b162bc6ec7. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Slow Test: src/frontend/[firefox] › pui_stock.spec.ts#L1
src/frontend/[firefox] › pui_stock.spec.ts took 36.1s
Slow Test: src/frontend/[chromium] › pui_tables.spec.ts#L1
src/frontend/[chromium] › pui_tables.spec.ts took 32.2s
Slow Test: src/frontend/[chromium] › pui_stock.spec.ts#L1
src/frontend/[chromium] › pui_stock.spec.ts took 26.2s
Slow Test: src/frontend/[firefox] › pui_printing.spec.ts#L1
src/frontend/[firefox] › pui_printing.spec.ts took 20.6s
Slow Test: src/frontend/[chromium] › pui_printing.spec.ts#L1
src/frontend/[chromium] › pui_printing.spec.ts took 19.5s
🎭 Playwright Run Summary
4 flaky [chromium] › pages/pui_scan.spec.ts:90:1 › PUI - Pages - Index - Scan (General) ──────────────── [chromium] › pui_general.spec.ts:71:1 › PUI - Sales ──────────────────────────────────────────── [firefox] › pages/pui_part.spec.ts:127:1 › PUI - Pages - Part - Pricing (Internal) ───────────── [firefox] › pui_general.spec.ts:71:1 › PUI - Sales ───────────────────────────────────────────── 86 passed (9.8m)

Artifacts

Produced during runtime
Name Size
frontend-build Expired
1.97 MB