Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small typescript cleanups #7685

Merged
merged 5 commits into from
Jul 18, 2024
Merged

Conversation

matmair
Copy link
Member

@matmair matmair commented Jul 18, 2024

This PR fixes a few small style issues with typescript. We might need to adjust the CI to keep those out in the future.

@matmair matmair added the Platform UI Related to the React based User Interface label Jul 18, 2024
@matmair matmair added this to the 0.16.0 milestone Jul 18, 2024
@matmair matmair self-assigned this Jul 18, 2024
@matmair matmair requested a review from SchrodingersGat as a code owner July 18, 2024 21:43
Copy link

netlify bot commented Jul 18, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit c72e0f9
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/66998c7987960c0008762091
😎 Deploy Preview https://deploy-preview-7685--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 92 (no change from production)
SEO: 70 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 17.50000% with 33 lines in your changes missing coverage. Please review.

Project coverage is 83.69%. Comparing base (cb2c220) to head (c72e0f9).
Report is 310 commits behind head on master.

Files with missing lines Patch % Lines
src/frontend/src/pages/Index/Scan.tsx 0.00% 10 Missing ⚠️
src/frontend/src/tables/part/PartThumbTable.tsx 0.00% 7 Missing ⚠️
...c/frontend/src/components/details/DetailsImage.tsx 14.28% 5 Missing and 1 partial ⚠️
src/frontend/src/components/modals/QrCodeModal.tsx 14.28% 3 Missing and 3 partials ⚠️
...Index/Settings/AccountSettings/SecurityContent.tsx 0.00% 2 Missing ⚠️
...frontend/src/pages/Index/Settings/UserSettings.tsx 50.00% 0 Missing and 1 partial ⚠️
src/frontend/src/tables/UploadAction.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7685      +/-   ##
==========================================
- Coverage   83.71%   83.69%   -0.03%     
==========================================
  Files        1104     1104              
  Lines       48821    48821              
  Branches     1570     1570              
==========================================
- Hits        40871    40860      -11     
- Misses       7543     7563      +20     
+ Partials      407      398       -9     
Flag Coverage Δ
pui 64.97% <17.50%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat SchrodingersGat merged commit 0a2817d into inventree:master Jul 18, 2024
26 checks passed
@SchrodingersGat SchrodingersGat deleted the small-fixes branch July 18, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform UI Related to the React based User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants