Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call Py_DECREF after using PyObject_GetAttrString in intel driver #3077

Merged
merged 2 commits into from
Jan 2, 2025
Merged

Call Py_DECREF after using PyObject_GetAttrString in intel driver #3077

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3d4cb9
Call 'Py_DECREF' after 'using 'PyObject_GetAttrString' in intel driver
anmyachev Dec 28, 2024
c0eac4f
Merge branch 'main' into amyachev/issue3007
anmyachev Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions third_party/intel/backend/driver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,10 +420,18 @@ def format_of(ty):
}}

// extract kernel metadata
int num_warps = PyLong_AsLong(PyObject_GetAttrString(kernel_metadata, "num_warps"));
int num_ctas = PyLong_AsLong(PyObject_GetAttrString(kernel_metadata, "num_ctas"));
int shared_memory = PyLong_AsLong(PyObject_GetAttrString(kernel_metadata, "shared"));
int threads_per_warp = PyLong_AsLong(PyObject_GetAttrString(kernel_metadata, "threads_per_warp"));
PyObject *num_warps_attr = PyObject_GetAttrString(kernel_metadata, "num_warps");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.python.org/3/c-api/object.html#c.PyObject_GetAttrString

int num_warps = PyLong_AsLong(num_warps_attr);
Py_DECREF(num_warps_attr);
PyObject *num_ctas_attr = PyObject_GetAttrString(kernel_metadata, "num_ctas");
int num_ctas = PyLong_AsLong(num_ctas_attr);
Py_DECREF(num_ctas_attr);
PyObject *shared_attr = PyObject_GetAttrString(kernel_metadata, "shared");
int shared_memory = PyLong_AsLong(shared_attr);
Py_DECREF(shared_attr);
PyObject *threads_per_warp_attr = PyObject_GetAttrString(kernel_metadata, "threads_per_warp");
int threads_per_warp = PyLong_AsLong(threads_per_warp_attr);
Py_DECREF(threads_per_warp_attr);

// extract cluster dims
PyObject *clusterDim = PyObject_GetAttrString(kernel_metadata, "cluster_dims");
Expand All @@ -434,6 +442,7 @@ def format_of(ty):
int clusterDimX = PyLong_AsLong(PyTuple_GetItem(clusterDim, 0));
int clusterDimY = PyLong_AsLong(PyTuple_GetItem(clusterDim, 1));
int clusterDimZ = PyLong_AsLong(PyTuple_GetItem(clusterDim, 2));
Py_DECREF(clusterDim);
// extract launch metadata
if (launch_enter_hook != Py_None){{
PyObject* args = Py_BuildValue("(O)", launch_metadata);
Expand Down Expand Up @@ -466,9 +475,7 @@ def format_of(ty):
return NULL;
}}

// return None
Py_INCREF(Py_None);
return Py_None;
Py_RETURN_NONE;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to align with nvidia

}}

static PyMethodDef ModuleMethods[] = {{
Expand Down