Call Py_DECREF after using PyObject_GetAttrString in intel driver
#3077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anatoly Myachev <[email protected]>
anmyachev
commented
Dec 28, 2024
| int num_ctas = PyLong_AsLong(PyObject_GetAttrString(kernel_metadata, "num_ctas")); | ||
| int shared_memory = PyLong_AsLong(PyObject_GetAttrString(kernel_metadata, "shared")); | ||
| int threads_per_warp = PyLong_AsLong(PyObject_GetAttrString(kernel_metadata, "threads_per_warp")); | ||
| PyObject *num_warps_attr = PyObject_GetAttrString(kernel_metadata, "num_warps"); |
There was a problem hiding this comment.
anmyachev
commented
Dec 28, 2024
| // return None | ||
| Py_INCREF(Py_None); | ||
| return Py_None; | ||
| Py_RETURN_NONE; |
There was a problem hiding this comment.
to align with nvidia
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure that the whole problem is in the use of this particular function, but I haven't found any other problem areas yet.