Don't use implicitly elapsed_time in autotuner
#3036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmyachev
added a commit
that referenced
this pull request
Dec 18, 2024
Signed-off-by: Anatoly Myachev <[email protected]>
|
@whitneywhtsang we can try the changes in #2484 on DLE runner, but we need to cherry-pick 2a4b818 into Pavel's branch |
benchmarks/triton_kernels_benchmark/gemm_postop_addmatrix_benchmark.py
Outdated
Show resolved
Hide resolved
benchmarks/triton_kernels_benchmark/gemm_postop_gelu_benchmark.py
Outdated
Show resolved
Hide resolved
benchmarks/triton_kernels_benchmark/gemm_preop_exp_benchmark.py
Outdated
Show resolved
Hide resolved
Let's cherry-pick this PR to |
ok, but let's use 2a4b818 (last commit in #2484) which compatible with changes on Pavel's branch |
whitneywhtsang
pushed a commit
that referenced
this pull request
Dec 18, 2024
Signed-off-by: Anatoly Myachev <[email protected]>
anmyachev
added a commit
that referenced
this pull request
Dec 18, 2024
This reverts commit 2a4b818.
|
Please rebase this PR. |
Signed-off-by: Anatoly Myachev <[email protected]>
Signed-off-by: Anatoly Myachev <[email protected]>
Signed-off-by: Anatoly Myachev <[email protected]>
Co-authored-by: Whitney Tsang <[email protected]>
Signed-off-by: Anatoly Myachev <[email protected]>
anmyachev
force-pushed
the
amyachev/autotuner
branch
from
c21c92a to
5710fd1
Compare
done |
|
I like the idea of this PR, but it looks like performance is not better: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main idea of this pull request is not to use
elapsed_timethat enable profiling mode for sycl queues, as this is not needed for profiling with PyTorch and PTI.CI runs: