Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: added jsonref to requirements.txt (Issue 1183) #1184

Closed
wants to merge 1 commit into from

Conversation

davesyms
Copy link

@davesyms davesyms commented Nov 14, 2024

Fixes issue #1183


Important

Add jsonref to requirements.txt to resolve issue #1183.

This description was created by Ellipsis for 9a1c676. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 9a1c676 in 7 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. requirements.txt:11
  • Draft comment:
    Add a newline at the end of the file for consistency and to follow best practices.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The file is missing a newline at the end, which is a best practice for text files.
2. requirements.txt:11
  • Draft comment:
    When adding a new library like jsonref to requirements.txt, ensure that relevant documentation is updated and tests are added or modified accordingly.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_eYtusTCZRaBHhql0


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@davesyms davesyms changed the title added jsonref to requirements.txt Fix: added jsonref to requirements.txt (Issue 1183) Nov 14, 2024
@ivanleomk ivanleomk closed this Nov 17, 2024
@ivanleomk
Copy link
Collaborator

Closing this for now since users are expected to install this dep using pip install "instructor[vertexai]

@Filimoa Filimoa mentioned this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants