Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsonref missing from requirements.txt #1183

Open
1 of 8 tasks
davesyms opened this issue Nov 14, 2024 · 2 comments
Open
1 of 8 tasks

jsonref missing from requirements.txt #1183

davesyms opened this issue Nov 14, 2024 · 2 comments
Labels
bug Something isn't working dependencies Pull requests that update a dependency file

Comments

@davesyms
Copy link

  • This is actually a bug report.
  • I am not getting good LLM Results
  • I have tried asking for help in the community on discord or discussions and have not received a response.
  • I have tried searching the documentation and have not found an answer.

What Model are you using?

  • gpt-3.5-turbo
  • gpt-4-turbo
  • gpt-4
  • Other (please specify)
  • [X ] Not Relevant

Describe the bug
client_vertexai.py imports jsonref on line 9. jsonref is not included in the requirements.txt

To Reproduce
If jsonref has not been installed on the venv running instructor.from_vertexai will result in a ValueError - instructor has no attribute from_vertexai. If directly importing: from instructor.client_vertexai import from_vertexai a module not found exception is thrown.

Expected behavior
For jsonref to be included in the requirements.txt.

@github-actions github-actions bot added bug Something isn't working dependencies Pull requests that update a dependency file labels Nov 14, 2024
@davesyms
Copy link
Author

Fixed in PR: #1184

@ivanleomk
Copy link
Collaborator

@davesyms hmm we only ship with openai as a dependency. you should be able to install the necessary deps using pip install "instructor[vertexai].

Curious if you saw that in the docs and if not, where would you prefer we put it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

2 participants