feat(mgmt): update metrics endpoints to serve new dashboard design #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvallesm
changed the title
jvallesm
force-pushed
the
jvalles/ins-5379-credit-dashboard-endpoints
branch
from
e4e7c4a
to
d1807cf
Compare
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
jvallesm
commented
Oct 16, 2024
jvallesm
commented
Oct 16, 2024
jvallesm
commented
Oct 16, 2024
The new path reflects that the endpoint isn't resource-oriented and that it is a custom method.
As a non-resource-based endpoint, this path is aligned with the pipeline and model chart endpoints.
jvallesm
force-pushed
the
jvalles/ins-5379-credit-dashboard-endpoints
branch
from
d7d4b49
to
5d4c17e
Compare
triggered by commit: 88d6802
jvallesm
requested review from
donch1989,
heiruwu,
pinglin and
xiaofei-du
as code owners
jvallesm
added a commit
to instill-ai/api-gateway
that referenced
this pull request
Nov 26, 2024
Because - Pipeline and credit endpoints have different params and schemas. - Some of the information served by the existing endpoints will be handled by the pipeline run feature. This commit - Applies contracts defined in instill-ai/protobufs#435
jvallesm
added a commit
to instill-ai/mgmt-backend
that referenced
this pull request
Nov 26, 2024
Because - The new dashboard introduces changes in the metrics endpoints. This commit - Applies contracts defined in instill-ai/protobufs#435, keeping the API backwards-compatible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This commit
GetPipelineTriggerCountpath is updated to align with API guidelines.ListCreditConsumptionChartRecordspath is updated to align with API guidelines (previous path will be kept in the gateway to keep the current UX running).ListPipelineTriggerChartRecordsis added.