-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mgmt): update metrics endpoints to serve new dashboard design #513
Conversation
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
7c2ba1e
to
a2a24c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some suggestions to improve the comments. Thanks for taking into account the notes on #435. You could have pushed your changes to that branch to avoid duplication (I don't mind handing over a PR or having changes pushed on top of mine 😄). If you could please close that PR once you merge this one, it'll remove some noise from the repo 🧹
e35f9ba
to
6af38dd
Compare
9371dfc
to
3076ab5
Compare
triggered by commit: e5b3470
We are planning to replace ListPipelineTriggerTableRecords URL: GetPipelineTriggerCount response will be like: {
"pipelineTriggerCounts":
[
{
"triggerCount": 3,
"status": "STATUS_COMPLETED"
}
]
} ListPipelineTriggerChartRecords response will be like: {
"pipelineTriggerChartRecords":
[
{
"timeBuckets":
[
"2024-11-07T01:00:00Z",
"2024-11-07T02:00:00Z",
"2024-11-07T03:00:00Z",
"2024-11-07T04:00:00Z",
"2024-11-07T05:00:00Z",
"2024-11-07T06:00:00Z",
"2024-11-07T06:41:33.706786732Z"
],
"triggerCounts":
[
0,
0,
0,
0,
0,
0,
3
],
"requesterId": "requesterId-A"
}
]
} URL of ListPipelineTriggerChartRecords will be changed from |
These changes will be tackled in #435, where the changes will be made in a backwards-compatible way so the frontend can implement the changes according to the devs' availability. Another PR will clean up the deprecated endpoints. |
Because
This commit