Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Separate Checkboxes for Telemetry and Newsletter Subscription in Onboarding Wizard #7447

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

pauloiankoski
Copy link
Contributor

@pauloiankoski pauloiankoski commented Jul 10, 2024

Resolves GIVE-966]

Description

Currently, we have a single route for users to accept or decline both sharing data for telemetry and subscribing to our newsletter. This pull request addresses that by adding separate checkboxes for these distinct cases. The telemetry opt-in is still in the Cause step, while the newsletter subscription is now in the Preview step.

Affects

Opt-in in the Onboarding Wizard

Visuals

dev givewp local_wp-admin__page=give-onboarding-wizard (2)
Cause step with Telemetry opt-in

dev givewp local_wp-admin__page=give-onboarding-wizard (3)
Preview step with Newsletter opt-in

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@pauloiankoski pauloiankoski force-pushed the refactor/onboarding-opt-ins branch from ff44c91 to 02b8cef Compare July 18, 2024 17:09
@pauloiankoski pauloiankoski marked this pull request as ready for review July 18, 2024 17:09
Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome this looks good & the POST requests seem to be working as they previously did.

@pauloiankoski pauloiankoski merged commit 436a18e into epic/onboarding-wizard Jul 18, 2024
20 checks passed
@pauloiankoski pauloiankoski deleted the refactor/onboarding-opt-ins branch July 18, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants