Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Update onboarding wizard to be compatible with v3 forms #7455

Merged
merged 10 commits into from
Jul 26, 2024
Merged

Refactor: Update onboarding wizard to be compatible with v3 forms #7455

merged 10 commits into from
Jul 26, 2024

Conversation

pauloiankoski
Copy link
Contributor

@pauloiankoski pauloiankoski commented Jul 22, 2024 •
edited
Loading

Resolves GIVE-1048

Description

This pull request updates the onboarding wizard, making it compatible with v3 forms and includes other changes as listed below:

Testing instructions

  • Confirm that navigation works through out the button but not longer through the nav bar.
  • Confirm that setting different options in the Features step generates a new v3 form correctly.

PS: Testing telemetry and newsletter subscriptions are only possible programmatically.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@pauloiankoski pauloiankoski marked this pull request as ready for review July 22, 2024 17:46
rickalday
rickalday approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests.

@pauloiankoski pauloiankoski merged commit c885b4b into develop Jul 26, 2024
32 checks passed
@pauloiankoski pauloiankoski deleted the epic/onboarding-wizard branch July 26, 2024 15:35
kjohnson pushed a commit that referenced this pull request Aug 21, 2024
@pauloiankoski @JoshuaHungDinh @kjohnson
Refactor: Update onboarding wizard to be compatible with v3 forms (#7455
9bdd668 
)

Co-authored-by: Joshua Dinh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickalday rickalday rickalday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pauloiankoski @rickalday @JoshuaHungDinh