Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Change how user navigates between steps in the Onboarding Wizard #7446

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

pauloiankoski
Copy link
Contributor

@pauloiankoski pauloiankoski commented Jul 10, 2024

Resolves GIVE-967

Description

This pull request changes how the user navigates between steps. It removes the ability to change the current step by clicking directly in the navigation bar and adds ‘Previous’ buttons to the steps. This way, we intend to guide the user to go through all the steps. Additionally, it brings enhancements to styling.

Affects

Navigation in the Onboarding Wizard

Visuals

CleanShot.2024-07-10.at.17.34.46.mp4

dev givewp local_wp-admin__page=give-onboarding-wizard(Desktop_ 1280x1024) (13)
Cause step

dev givewp local_wp-admin__page=give-onboarding-wizard(Desktop_ 1280x1024) (14)
Location step

dev givewp local_wp-admin__page=give-onboarding-wizard(Desktop_ 1280x1024) (15)
Features step

dev givewp local_wp-admin__page=give-onboarding-wizard(Desktop_ 1280x1024) (16)

Preview step

dev givewp local_wp-admin__page=give-onboarding-wizard(Desktop_ 1280x1024) (17)
Add-ons step

Testing Instructions

In the Onboarding Wizard, guarantee that you can move forward and backaward.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@pauloiankoski pauloiankoski changed the title refactor: replace text on Introduction step Refactor: Change how user navigates between steps in the Onboarding Wizard Jul 10, 2024
@pauloiankoski pauloiankoski marked this pull request as ready for review July 15, 2024 18:27
@pauloiankoski pauloiankoski force-pushed the refactor/onboarding-navigation branch from 1d81bf4 to f1d92ed Compare July 15, 2024 18:31
Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, so Is it safe to assume you plan to update screen 1 "Cause" later?

Also, not a big deal but why does confetti image look different?
Screen Shot 2024-07-17 at 3 26 42 PM

@pauloiankoski
Copy link
Contributor Author

Yeah. The last PR is the one that replaces that Accept and Continue button with a checkbox. Regarding confetti, that's an emoji and can be rendered differently according to the system. Do you mind trying it on Chrome or Safari?

@JoshuaHungDinh
Copy link
Contributor

Yeah. The last PR is the one that replaces that Accept and Continue button with a checkbox. Regarding confetti, that's an emoji and can be rendered differently according to the system. Do you mind trying it on Chrome or Safari?

Interesting, yea its red on Safari, Chrome & Opera for me. I don't think it should hold the PR up. I was just wondering. This tests out perfect and the code LGTM. I say we move this forward!

@JoshuaHungDinh JoshuaHungDinh self-requested a review July 17, 2024 22:43
@pauloiankoski pauloiankoski merged commit 901c87c into epic/onboarding-wizard Jul 18, 2024
20 checks passed
@pauloiankoski pauloiankoski deleted the refactor/onboarding-navigation branch July 18, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants