Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add additional escaping to stripe onboarding #7391

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Fix: add additional escaping to stripe onboarding #7391

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0791d20
fix: add esc_attr to session_id redirect
May 16, 2024
f212aed
docs: add since tag
May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/PaymentGateways/Gateways/Stripe/Traits/CheckoutRedirect.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ public function getRedirectUrl( $sessionId, $formId )
}

/**
* @unreleased add esc_attr to $session_id
* @since 2.5.5
* @since 2.19.0 Migrated from the legacy Give_Stripe_Checkout::redirect_to_checkout implementation of the Stripe Checkout Gateway.
* @return void
Expand Down Expand Up @@ -83,7 +84,7 @@ public static function maybeHandleRedirect()
// Make the id field from the Checkout Session creation API response
// available to this file, so you can provide it as parameter here
// instead of the {{CHECKOUT_SESSION_ID}} placeholder.
sessionId: '<?php echo $session_id; ?>'
sessionId: '<?php echo esc_attr($session_id); ?>'
}).then( ( result ) => {
console.log(result);
// If `redirectToCheckout` fails due to a browser or network
Expand Down
Loading