Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: add additional escaping to stripe onboarding #7391

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Fix: add additional escaping to stripe onboarding #7391

merged 2 commits into from
Jun 3, 2024

Conversation

jonwaldstein
Copy link
Contributor

@jonwaldstein jonwaldstein commented May 16, 2024 •
edited
Loading

Resolves GIVE-720

Description

This adds additional escaping to our stripe onboarding

Affects

The stripe settings onboarding

Visuals

N/A

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@jonwaldstein jonwaldstein changed the base branch from develop to master May 16, 2024 14:00
@jonwaldstein jonwaldstein changed the title Fix: add additional escaping to stripe checkout Fix: add additional escaping to stripe onboarding May 17, 2024
@jonwaldstein jonwaldstein marked this pull request as ready for review May 28, 2024 20:15
@pauloiankoski pauloiankoski self-requested a review May 28, 2024 21:47
pauloiankoski
pauloiankoski approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@pauloiankoski pauloiankoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Let's ship it to QA.

rickalday
rickalday approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed QA tests

@jonwaldstein jonwaldstein changed the base branch from master to develop June 3, 2024 20:22
@jonwaldstein jonwaldstein merged commit da11d76 into develop Jun 3, 2024
20 checks passed
@jonwaldstein jonwaldstein deleted the fix/GIVE-720 branch June 3, 2024 20:23
kjohnson pushed a commit that referenced this pull request Aug 21, 2024
@jonwaldstein @kjohnson
Fix: add additional escaping to stripe onboarding (#7391)
032fc8a 
Co-authored-by: Jon Waldstein <[email protected]>
Co-authored-by: Jon Waldstein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauloiankoski pauloiankoski pauloiankoski approved these changes

@rickalday rickalday rickalday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonwaldstein @rickalday @pauloiankoski