Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Change v2 to v3 migration to include level descriptions #7362

Conversation

pauloiankoski
Copy link
Contributor

@pauloiankoski pauloiankoski commented Apr 23, 2024

Resolves GIVE-668

Description

Update the DonationOptions step in Form Migrations to align with the new donation levels schema, and migrate the level description accordingly.

Affects

DonationOptions migration from v2 to v3 forms

Visuals

CleanShot.2024-04-23.at.16.55.20.mp4

Testing Instructions

  1. Create a v2 form using donation levels.
  2. Migrate that form to v3.
  3. Confirm that levels have been migrated properly.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@jonwaldstein
Copy link
Contributor

@pauloiankoski could you do me a favor and add a test to TestDonationOptions for this? - I started that unit test a while ago and would love to keep adding to it 😄

@pauloiankoski
Copy link
Contributor Author

@jonwaldstein Yeah! No problem! Will do it right now.

@pauloiankoski pauloiankoski merged commit 5162654 into epic/donation-amount-level-descriptions Apr 23, 2024
20 checks passed
@pauloiankoski pauloiankoski deleted the refactor/donation-level-texts-migration branch April 23, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants