-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Epic: add donation amount level descriptions #7364
Epic: add donation amount level descriptions #7364
Conversation
…onsEnabled (#7355) Co-authored-by: Paulo Iankoski <[email protected]>
5d1ddd8
to
0d1ec0c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passed manual QA tests.
src/DonationForms/resources/registrars/templates/fields/Amount/DonationAmountLevels.tsx
Outdated
Show resolved
Hide resolved
48ba42b
to
a7c7761
Compare
e36ab4f
to
6d97fd8
Compare
@pauloiankoski @JoshuaHungDinh I tried to run build and i'm getting an error, do we need another form builder library release? |
@jonwaldstein Indeed. We have implemented the max length in the description field. Without updating the package, the PR might break. |
@pauloiankoski okay good to know, in the future we don't want to merge features that depend on external releases until it's safe to do so - in this case we needed the form builder library release before we can merge the implementation PR. This would be an example of a blocker that you can raise to me to help unblock. |
@pauloiankoski @JoshuaHungDinh @rickalday I'd like to add an additional QA test to confirm the donation level schema migration for backwards compatibility.
We need to confirm existing donation amount blocks are migrated to the new schema successfully. This is very important to make sure or else it could significantly impact existing donation amount fields. Side note @pauloiankoski I believe we can write a unit test for the I ran into this issue that could very well be a js cache'ing problem on my end - but it made me want to circle back and confirm the migration. |
4a2c6a5
to
ca0b514
Compare
@jonwaldstein Test implemented on ca0b514 |
@JoshuaHungDinh @pauloiankoski I updated the form builder library to new version 0.6.0 |
Resolves: GIVE-577
Requires: Form Builder Library release
Zeplin Design
Description
This task involves enhancing the Donation Amount block by adding text descriptions to be associated with each donation level. The default state of descriptions is disabled, however a toggle is now available to enable descriptions. Once enabled text area input fields are shown for each level.
To accomplish this we have reduced all the previously split attributes for the level into a single levels attribute. The levels attribute now holds default value, the level value, the label(description) & an optional id.
Additional changes:
Pull Requests:
Fix: Update Currency Switcher integration #7366
Refactor: Update DonationAmountLevels template to support descriptions #7363
Refactor: Change v2 to v3 migration to include level descriptions #7362
Refactor: Merge block level attributes #7361
Refactor: update amount node conversion with descriptions & descriptionsEnabled #7355
Feature: add level descriptions block-placeholder #7354
Feature: update amount block settings with descriptions #7353
Refactor: update price option settings control #7350
Affects
The Donation Amount block.
Visuals
donation.type.control.mov
description.formbuilder.mov
Frontend.UI.mov
Testing Instructions
Donation Type Control:
Descriptions FormBuilder Preview/Controls:
Frontend UI:
v2 -> v3 Migration:
Pre-review Checklist
@unreleased
tags included in DocBlocks