Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add level descriptions block-placeholder #7354

Conversation

JoshuaHungDinh
Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh commented Apr 16, 2024

Resolves: GIVE-621

Description

This PR updates the blockplaceholder to handle level descriptions.

Affects

VFB Donation Amount Block

Visuals

Testing Instructions

  • When selecting between multi or fixed donation amounts, the placeholder should visually show the selected option with a different background color & font.
  • Add some descriptions and ensure they are displayed correctly in the new design for multi level donations with descriptions.
  • If a description is not filled it should have a placeholder text.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@JoshuaHungDinh JoshuaHungDinh changed the base branch from develop to epic/donation-amount-level-descriptions April 16, 2024 02:34
@JoshuaHungDinh JoshuaHungDinh marked this pull request as ready for review April 16, 2024 02:41
@JoshuaHungDinh JoshuaHungDinh merged commit 2f9b92f into epic/donation-amount-level-descriptions Apr 23, 2024
20 checks passed
@JoshuaHungDinh JoshuaHungDinh deleted the refactor/level-descriptions-preview branch April 23, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants