Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: update price option settings control #7350

Merged
merged 7 commits into from
Apr 15, 2024
Merged

Refactor: update price option settings control #7350

merged 7 commits into from
Apr 15, 2024

Conversation

JoshuaHungDinh
Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh commented Apr 11, 2024 •
edited
Loading

Resolves: GIVE-625

Description

https://app.zeplin.io/project/654141b179b50d20560405c8/screen/6616a7049fb6e9766e98a3e5

This PR aims to improve the priceOption setting controls from within the amount blocks inspector controls.

Changes:

  • Remove DonationLevels dropdown & move the amount options into DonationOptions dropdown. The conditional for which priceOption should show was updated to a ternary conditional.
  • Replace the SelectControl WP component with a custom control using the proposed new design.

Affects

Donation Amount Controls

Visuals

Screen.Recording.2024-04-11.at.4.06.30.PM.mov

Testing Instructions

  • Toggle the new control
  • Verify the correct donation amount input is displayed when the corresponding setting is chosen
  • Verify the build preview updates with the correct donation amount preview

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@JoshuaHungDinh JoshuaHungDinh changed the base branch from develop to epic/donation-amount-level-descriptions April 11, 2024 23:23
@JoshuaHungDinh JoshuaHungDinh marked this pull request as ready for review April 11, 2024 23:25
@JoshuaHungDinh JoshuaHungDinh merged commit 184cb43 into epic/donation-amount-level-descriptions Apr 15, 2024
20 checks passed
@JoshuaHungDinh JoshuaHungDinh deleted the refactor/update-donation-type-settings branch April 15, 2024 23:39
@JoshuaHungDinh JoshuaHungDinh mentioned this pull request Apr 24, 2024
Merged
5 tasks
pauloiankoski pushed a commit that referenced this pull request Apr 24, 2024
@JoshuaHungDinh @pauloiankoski
Refactor: update price option settings control (#7350)
fbdd055
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauloiankoski pauloiankoski pauloiankoski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshuaHungDinh @pauloiankoski