Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: create responsive previews in the form builder #7212

Merged
merged 13 commits into from
Jul 9, 2024
+24 −17
Merged

Refactor: create responsive previews in the form builder #7212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
60c4caf
refactor: calculate sidebar width into the skeleton body.
JoshuaHungDinh Jan 30, 2024
0ec3eb3
refactor: remove width calc on skeleton body
JoshuaHungDinh Feb 29, 2024
7f6fcc5
feature: add height to skeleton content
JoshuaHungDinh Feb 29, 2024
2fb1af4
refactor: remove fixed positioning
JoshuaHungDinh Feb 29, 2024
3855494
Refactor: adjust sidebar to fit viewheight
JoshuaHungDinh Mar 5, 2024
a836fe2
refactor: align block canvas content
JoshuaHungDinh Mar 7, 2024
c85f32d
refactor: update attachTo element in shepard to respect changes in th…
JoshuaHungDinh May 22, 2024
8f4bf6d
refactor: adjust max-width
JoshuaHungDinh May 22, 2024
a0e5201
refactor: add spacing between sidebar and 2panel
JoshuaHungDinh May 24, 2024
4b34aa7
refactor: move width of build content
JoshuaHungDinh Jun 25, 2024
9742998
refactor: add minimal space between content and sidebars for small sc…
JoshuaHungDinh Jun 25, 2024
7b0ce1c
Merge branch 'develop' into fix/sidebar-panel-overlap
JoshuaHungDinh Jun 25, 2024
da26bdb
refactor: account for header in skeleton body content to keep sidebar…
JoshuaHungDinh Jul 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/DonationForms/FormDesigns/TwoPanelStepsFormLayout/css/_container.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@
flex-direction: row;
margin: auto;
max-width: calc(var(--two-panel-header-width) + 35.5rem);
padding: 0;
padding: 0 .5rem;
width: 100%;

@media screen and (max-width: 71.5rem) {
@media screen and (max-width: 53.5rem) {
border: solid 1px var(--givewp-grey-25);
border-radius: var(--givewp-rounded-8);
box-shadow: var(--givewp-shadow-sm);
Expand Down
2 changes: 1 addition & 1 deletion src/FormBuilder/resources/js/form-builder/src/components/onboarding/steps/schema-steps.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import Placement from '@givewp/form-builder/components/onboarding/steps/types/pl
const schemaSteps = [
{
id: 'schema-canvas',
attachTo: {element: '#form-blocks-canvas', on: 'right-start' as Placement},
attachTo: {element: '#form-blocks-canvas > div', on: 'right-start' as Placement},
title: __('Canvas', 'give'),
text: __('Add, reorder, and edit blocks and sections here to make up your form.', 'give'),
},
Expand Down
19 changes: 16 additions & 3 deletions src/FormBuilder/resources/js/form-builder/src/styles/_block-editor.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
.interface-interface-skeleton__body {
width: 100%;
background-color: var(--givewp-gray-10);
overflow: hidden;
}

.interface-interface-skeleton__secondary-sidebar {
Expand All @@ -34,15 +35,21 @@
}

.interface-interface-skeleton__content {
width: 720px;
margin: 0 auto auto;
height: calc(100vh - 60px);
width: 100%;
margin: auto;
padding: 100px 0; /* Leave room for toolbar above first block. */
flex-grow: unset;
box-sizing: border-box;

.givewp-form-builder__design-tab & {
display: block;
width: 100%;
max-width: 1200px;
}

#form-blocks-canvas {
display: flex;
justify-content: center;
}

@media screen and (max-width: 782px) {
Expand Down Expand Up @@ -206,6 +213,9 @@
gap: 2rem;

.block-editor-block-list__block {
max-width: 720px;
padding: 0 0.5rem;

&:not([contenteditable]):focus::after {
box-shadow: none;
}
Expand Down Expand Up @@ -296,3 +306,6 @@
}
}

.givewp-form-settings__editor .interface-interface-skeleton {
width: 100%;
}
16 changes: 5 additions & 11 deletions src/FormBuilder/resources/js/form-builder/src/styles/_form-builder.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,15 +42,12 @@
border: 1px solid lightgray;
bottom: 0;
//color: slategray;
height: calc(100vh - 60px); // Account for header height above sidebar
height: calc(100vh - 65px); // Account for header height above sidebar
//overflow: hidden; // The Inspector Popout needs to be visible.
position: fixed !important; // !important override added when migrated to WordPress - not sure why this is necessary...
top: 60px; // Account for header @todo move this to layout, not in the component.
overflow-y: scroll;

&.givewp-next-gen-sidebar-primary {
right: 0;

&.givewp-next-gen-sidebar-primary {
.block-editor-block-inspector {
> h2 {
border-bottom: 1px solid #e0e0e0;
Expand All @@ -70,10 +67,6 @@
}
}

&.givewp-next-gen-sidebar-secondary {
left: 0;
}

&__inner {
padding: 1rem;
}
Expand Down Expand Up @@ -249,7 +242,7 @@
}
}

&_visibility{
&_visibility {
font-size: 0.75rem;
line-height: 1.4;
margin-top: -8px;
Expand Down Expand Up @@ -309,7 +302,8 @@
fill: #000;
stroke: #fff;
}
};
}
;
}

.iti {
Expand Down
Loading