Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: create responsive previews in the form builder #7212

Merged
merged 13 commits into from
Jul 9, 2024

Conversation

JoshuaHungDinh
Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh commented Jan 30, 2024

Resolves GIVE-268

Description

This pull request (PR) introduces enhancements to achieve a width-responsive preview in the form builder by removing the sidebars from their fixed positioning. This creates a more similar experience as the WP block editor.

Changes include:
interface-interface-skeleton__content

  • Set height to allow content to be scrolled
  • Set overflow-y to allow content to scroll

.interface-interface-skeleton__body

  • Hide overflow so entire body does not scroll

.givewp-next-gen-sidebar

  • remove fixed positioning

Affects

The visual form builder sidebars

Visuals

Screen.Recording.2024-02-29.at.11.22.24.AM.mov

Testing Instructions

  • Toggle the sidebars on each form builder section'Build', 'Design' & 'Settings', the content section should expand and retract accordingly.
  • Each sidebar should be scrollable.
  • The preview content should be scrollable.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@JoshuaHungDinh JoshuaHungDinh marked this pull request as ready for review January 31, 2024 18:30
@JoshuaHungDinh JoshuaHungDinh force-pushed the fix/sidebar-panel-overlap branch from 7784ae5 to a836fe2 Compare May 22, 2024 14:46
Copy link
Contributor

@pauloiankoski pauloiankoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoshuaHungDinh Nice job on making this finally work! I have only very tiny suggestions for you. On .interface-interface-skeleton__content, set the height to be calc(100vh - 60px), discounting the heading bar so that the scrollbar doesn't go over the end of the page. After that, you may need to reduce the lower padding a little bit to make it look nicer.

… from extending past the form builders visual height
@JoshuaHungDinh
Copy link
Contributor Author

@pauloiankoski Resolved: da26bdb

Copy link
Contributor

@pauloiankoski pauloiankoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go! 👏🏻 👏🏻 👏🏻

Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests.

@JoshuaHungDinh JoshuaHungDinh merged commit a04d5a8 into develop Jul 9, 2024
20 checks passed
@JoshuaHungDinh JoshuaHungDinh deleted the fix/sidebar-panel-overlap branch July 9, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants