-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: create responsive previews in the form builder #7212
Conversation
7784ae5
to
a836fe2
Compare
…e canvas skeleton
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JoshuaHungDinh Nice job on making this finally work! I have only very tiny suggestions for you. On .interface-interface-skeleton__content
, set the height to be calc(100vh - 60px)
, discounting the heading bar so that the scrollbar doesn't go over the end of the page. After that, you may need to reduce the lower padding a little bit to make it look nicer.
… from extending past the form builders visual height
@pauloiankoski Resolved: da26bdb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go! 👏🏻 👏🏻 👏🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passed manual QA tests.
Resolves GIVE-268
Description
This pull request (PR) introduces enhancements to achieve a width-responsive preview in the form builder by removing the sidebars from their fixed positioning. This creates a more similar experience as the WP block editor.
Changes include:
interface-interface-skeleton__content
.interface-interface-skeleton__body
.givewp-next-gen-sidebar
Affects
The visual form builder sidebars
Visuals
Screen.Recording.2024-02-29.at.11.22.24.AM.mov
Testing Instructions
Pre-review Checklist
@unreleased
tags included in DocBlocks