Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bundling of DLLs on Windows #534

Closed
wants to merge 2 commits into from
Closed

Fix bundling of DLLs on Windows #534

wants to merge 2 commits into from

Conversation

alexdewar
Copy link
Contributor

@alexdewar alexdewar commented Sep 25, 2024

Solved using advice from here: https://stackoverflow.com/questions/10671916/how-to-copy-dll-files-into-the-same-folder-as-the-executable-using-cmake/69736197#69736197

Both local builds and the CI generated binaries now work.

I've also added steps to the CI to check that HealthGPS.Console will run with the --help flag, which should catch these sorts of problem in future.

I'm now hitting another error when actually running the program 😞 , but I'll open a separate issue for this.

Fixes #533.

@alexdewar alexdewar force-pushed the fix-bundle-dlls branch 2 times, most recently from 1bd31dc to cfcb176 Compare September 25, 2024 15:39
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.12%. Comparing base (9a6e7e3) to head (e25ece9).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #534      +/-   ##
==========================================
+ Coverage   48.82%   49.12%   +0.30%     
==========================================
  Files         164      164              
  Lines        7779     7796      +17     
  Branches     1059     1063       +4     
==========================================
+ Hits         3798     3830      +32     
+ Misses       3972     3957      -15     
  Partials        9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexdewar alexdewar force-pushed the fix-bundle-dlls branch 2 times, most recently from 7e5a552 to bf3c132 Compare September 26, 2024 14:07
@alexdewar alexdewar marked this pull request as ready for review September 26, 2024 15:12
Scan the executable to figure out the dependencies and copy them into the install folder.

Fixes #533.
@alexdewar
Copy link
Contributor Author

Actually, I'll make a single PR for all the Windows-related fixes. Don't bother reviewing this.

@alexdewar alexdewar closed this Sep 27, 2024
@alexdewar alexdewar mentioned this pull request Sep 27, 2024
@alexdewar alexdewar deleted the fix-bundle-dlls branch September 30, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Missing DLLs for Windows binaries
1 participant