Various Windows fixes

[alexdewar]

This PR fixes the Windows (MSVC) build of HGPS.

There were a few issues I had in trying to get HGPS to run on Windows:

1. A bunch of dependent DLLs were missing from the install directory, meaning both local and CI builds wouldn't run. Fixed by scanning the exe for depending DLLs and including them.
2. There were a few places where fstreams were being opened in text mode rather than binary mode, which won't work with binary files on Windows
3. A trailing slash on the end of directory names was breaking things

Fixes #533. Fixes #536.

[codecov]

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 49.12%. Comparing base (46c27c1) to head (75d6469).
Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
src/HealthGPS.Input/zip_file.cpp	0.00%	2 Missing ⚠️
src/HealthGPS.Input/download_file.cpp	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #537      +/-   ##
==========================================
+ Coverage   48.72%   49.12%   +0.40%     
==========================================
  Files         164      164              
  Lines        7795     7796       +1     
  Branches     1063     1062       -1     
==========================================
+ Hits         3798     3830      +32     
+ Misses       3988     3957      -31     
  Partials        9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[alexdewar]

Btw: Windows binaries should work fine with wine. I had to install the Visual C++ redist library too: winetricks vcrun2022

It's handy if you want to test that the CI-generated Windows binaries work without having to boot Windows.

[jamesturner246]

Okay. Not sure I understand the CMake changes, RUNTIME, ARCHIVE, LIBRARY, RUNTIME, .... And esp. the windows part.

Also is the create directory exception not needed anymore?

I trust it's right, so LGTM.

[jamesturner246]

Don't need the exception any more?

[alexdewar]

Okay. Not sure I understand the CMake changes, RUNTIME, ARCHIVE, LIBRARY, RUNTIME, .... And esp. the windows part.

I don't entirely understand why those bits were needed either 🙃. I copied from here: https://stackoverflow.com/questions/10671916/how-to-copy-dll-files-into-the-same-folder-as-the-executable-using-cmake

The bit about installing RUNTIME_DEPENDENCIES just figures out what DLLs are needed for the EXE, excluding system libraries, and copies them to the install folder.

Also is the create directory exception not needed anymore?

I was getting spurious failures here, I think because the extra . causes Windows to try to create a directory twice which fails. Yuck. Anyway, it works fine if we just assume that directories are created successfully and raise errors if creating files fails.