Ensure unique ordering for function get_all_nodes #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knarfnitram
force-pushed
the
ensure-unique-ordering-for-get-all-nodes
branch
2 times, most recently
from
b6f97b0
to
31aa36d
Compare
isteinbrecher
force-pushed
the
ensure-unique-ordering-for-get-all-nodes
branch
from
31aa36d
to
82e8c5e
Compare
knarfnitram
force-pushed
the
ensure-unique-ordering-for-get-all-nodes
branch
from
82e8c5e
to
f1de55f
Compare
|
@knarfnitram thanks for the changes! Performance tests also pass, so the added sort functionality should at least not completely break the performance. Feel free to merge. |
|
Thanks @isteinbrecher for helping with the sort. |
isteinbrecher
force-pushed
the
ensure-unique-ordering-for-get-all-nodes
branch
from
f1de55f
to
098ce4c
Compare
|
@knarfnitram I pushed a minor documentation fix. So you will need to rebase |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During #126 I encountered non-deterministic behavior for the function
get_all_nodes, when they are used from a geometry based on a line set.To ensure the same numbering of the nodes, some adjustments were made and a test case is added.