Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpolate dbc monitor input #126

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

knarfnitram
Copy link
Collaborator

@knarfnitram knarfnitram commented Nov 13, 2024

This MR adds the functionality to extract all nodal force values of a previous simulation and adds them to a new simulation as Neuman condition. With the previous functionality, only the last values of the force were used.

Note:
This MR has been split into #127 and #128 to reduce the complexity.

meshpy/geometry_set.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@isteinbrecher isteinbrecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @knarfnitram . I left some first comments.

tests/testing_meshpy.py Outdated Show resolved Hide resolved
tests/testing_meshpy.py Outdated Show resolved Hide resolved
tests/testing_meshpy.py Outdated Show resolved Hide resolved
tests/testing_meshpy.py Outdated Show resolved Hide resolved
tests/testing_meshpy.py Outdated Show resolved Hide resolved
tests/testing_utility.py Outdated Show resolved Hide resolved
tests/testing_four_c_simulation.py Outdated Show resolved Hide resolved
meshpy/geometry_set.py Outdated Show resolved Hide resolved
meshpy/four_c/dbc_monitor.py Outdated Show resolved Hide resolved
meshpy/utility.py Outdated Show resolved Hide resolved
@knarfnitram knarfnitram force-pushed the interpolate_dbc_monitor_input_final branch from 0e2b45d to 9283a7e Compare November 14, 2024 11:05
.github/workflows/testing.yml Outdated Show resolved Hide resolved
.github/workflows/testing.yml Outdated Show resolved Hide resolved
@knarfnitram knarfnitram force-pushed the interpolate_dbc_monitor_input_final branch from 9283a7e to 7abb03f Compare November 14, 2024 14:11
@knarfnitram knarfnitram force-pushed the interpolate_dbc_monitor_input_final branch 5 times, most recently from bcbb8f0 to a1ac85b Compare November 18, 2024 17:38
@knarfnitram
Copy link
Collaborator Author

Pipeline or local testing is still failing due to wrong ordering of nodes within DNODE-NODE TOPOLOGY , so it seems that #128 does not cover this example?
Values left are the one from the test machine. Value's at right are chosen from my local machine:
Screenshot from 2024-11-18 18-23-36
By adapting the variables within commit bcbb8f0, the pipelines are passing.
However, I am not happy with the overall design of the test, since it seems to be machine dependant.

@knarfnitram knarfnitram force-pushed the interpolate_dbc_monitor_input_final branch from 25e3631 to addb568 Compare November 18, 2024 17:55
Key Features are:
 - forces of a previous simulation gets extracted.
 - Applyies those forces componentwise with a linear interpolation function to 4c.
@knarfnitram knarfnitram force-pushed the interpolate_dbc_monitor_input_final branch from 5292676 to def8239 Compare November 20, 2024 08:53
@knarfnitram
Copy link
Collaborator Author

@isteinbrecher Thanks for the hint with os.walk now everything is working as supposed.
Again Ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants