Added several chain controls #29161
Added several chain controls #29161
Conversation
|
Job Documentation, step Docs: sync website on 4ac8a27 wanted to post the following: View the site here This comment will be updated on new commits. |
framework/doc/content/source/chaincontrols/LimitChainControl.md
Outdated
Show resolved
Hide resolved
framework/doc/content/source/chaincontrols/ScaleOldChainControl.md
Outdated
Show resolved
Hide resolved
|
|
||
| protected: | ||
| /// Minimum value to apply to control data | ||
| const Real _min_value; |
There was a problem hiding this comment.
would be nice to have these be references to Reals from other ChainControls?
There was a problem hiding this comment.
It would, but I'd prefer that the user not be required to add chain controls for the bounds if they just want constant values. To get the best of both approaches, I think we'd need to do some work to allow constants to be able to be supplied for control data parameters, and I'd prefer to do that work when it becomes needed.
| protected: | ||
| /// Minimum value to apply to control data | ||
| const Real _min_value; | ||
| /// Maximum value to apply to control data |
There was a problem hiding this comment.
| /// Maximum value to apply to control data | |
| /// Maximum value to restrict control data |
There was a problem hiding this comment.
Changed wording to "Lower/upper bound to apply to"
| 47,4.8295863577061 | ||
| 48,4.628367040742 | ||
| 49,4.8920922443363 | ||
| 50,4.6075489928787 |
There was a problem hiding this comment.
seen some closer numbers to 5.
does it make it there eventually?
There was a problem hiding this comment.
It gets there very slowly - just wanted to show that it's converging. However, I do see that these parameters get there in an oscillatory fashion, so I'm going to change and re-gold.
Co-authored-by: Guillaume Giudicelli <[email protected]>
Refs #28948