fix(trip form): add callback for detecting when all submodes are disabled #28
Conversation
BREAKING CHANGE: removes mode subsettings panel Co-authored-by: Daniel Heppner <[email protected]> Co-authored-by: Amy Corson <[email protected]>
josh-willis-arcadis
requested review from
josh-willis-arcadis and
amy-corson-ibigroup
and removed request for
josh-willis-arcadis
josh-willis-arcadis
assigned amy-corson-ibigroup and unassigned daniel-heppner-ibigroup and josh-willis-arcadis
amy-corson-ibigroup
assigned daniel-heppner-ibigroup and unassigned amy-corson-ibigroup
There was a problem hiding this comment.
Are the mock buttons intended to be used outside Storybook? Renaming this file will result in the contents to ship in the binary packages.
There was a problem hiding this comment.
This was renamed because the build on the new version of storybook was failing. When .story is in the filename, a story is expected and there is no story in this file. These mocks are not used anywhere else besides storybook.
There was a problem hiding this comment.
I just realized there is a __mocks__ folder for this package, could you move mockButtons.tsx into that folder?
packages/trip-form/src/MetroModeSelector/AdvancedModeSettingsButton.story.tsx
Show resolved
Hide resolved
| @@ -111,7 +120,8 @@ export default { | |||
| argTypes: { | |||
| fillModeIcons: { control: "boolean" }, | |||
| onSetModeSettingValue: { action: "set mode setting value" }, | |||
| onToggleModeButton: { action: "toggle button" } | |||
| onToggleModeButton: { action: "toggle button" }, | |||
| onAllSubmodesDisabled: { action: "all submodes disabled" } | |||
There was a problem hiding this comment.
I don't see "all submodes disabled" appearing in the Storybook action pane, did I miss something?
There was a problem hiding this comment.
I don't see "all submodes disabled" appearing in the Storybook action pane, did I miss something?
I pulled a previous commit, sorry, ignore that comment.
josh-willis-arcadis
changed the title
josh-willis-arcadis
changed the base branch from
wide-mode-buttons
to
master
This PR adds a callback to detect when all the submodes under a mode button have been disabled. This will allow us to disable the mode button when all its submodes have been turned off.