Add c++ symbol support in xinfo. #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
More example symbol names in C++: |
hugsy
approved these changes
Dec 20, 2023
|
thank-you for reviewing the PR! |
Grazfather
reviewed
Dec 21, 2023
|
updated and addressed comments. |
2 tasks
Grazfather
pushed a commit
that referenced
this pull request
Dec 22, 2023
This change renames the tests.utils._target function to tests.utils.debug_target Currently, many tests are required to access the `_target` function in test_utils for building proper test cases. Hence, it is better to remove the _ prefix for this function, give it a more proper name, really make it public. This requirement comes from the discussion here: #1028 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds c++ symbol support in xinfo.
Currently, when using xinfo to get the symbol information in C++ programs, we might get incomplete data as below:
This is because the gdb_get_location_from_symbol function could not handle space in the symbol name.
This change updates the gdb_get_location_from_symbol, so we can handle the space. It makes
xinfoproduces expected result.Here is the screenshot that demos the output after the change:
