Rename _target to debug_target for building test cases. #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Grazfather , as promised below, please let me know how it looks : D
|
r12f
changed the title
hugsy
approved these changes
Dec 22, 2023
|
Great work with all those PRs. |
|
Thank-you for creating GEF! It is really helpful! Happy to become one of the contributors! |
Grazfather
requested changes
Dec 22, 2023
r12f
force-pushed
the
user/r12f/target
branch
from
b05fced to
16644cf
Compare
Grazfather
approved these changes
Dec 22, 2023
|
awesome! thanks a lot for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change renames the tests.utils._target function to tests.utils.debug_target
Currently, many tests are required to access the
_targetfunction in test_utils for building proper test cases. Hence, it is better to remove the _ prefix for this function, give it a more proper name, really make it public.This requirement comes from the discussion here: #1028 (comment).