Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add experiment tracking integration to text, image classification & LLM finetuning #301

Merged
merged 11 commits into from
Oct 22, 2023

Conversation

rishiraj
Copy link
Contributor

@rishiraj rishiraj commented Oct 16, 2023

Worked with @soumik12345 from WandB team to successfully integrate WandB with LLM Finetuning, text & image classification. Tests are passing. Here is a notebook I used to test: https://colab.research.google.com/drive/1m0KZzcCuKRn3Rkff32XTvdIfD45hK2Va?usp=sharing

@rishiraj rishiraj marked this pull request as ready for review October 16, 2023 15:52
Copy link
Member

@abhishekkrthakur abhishekkrthakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Eventually, multiple logging should be supported. Currently, we already have tensorboard. In order to get this PR merged, we need to change how the API works. The CLI should have a --log argument which can take inputs like tensorboard and wandb. --log wandb should log to wandb and so on. if nothing is provided, no logging. please let me know if the requirements are unclear

@rishiraj
Copy link
Contributor Author

Thanks for the PR. Eventually, multiple logging should be supported. Currently, we already have tensorboard. In order to get this PR merged, we need to change how the API works. The CLI should have a --log argument which can take inputs like tensorboard and wandb. --log wandb should log to wandb and so on. if nothing is provided, no logging. please let me know if the requirements are unclear

The requirements are clear. I am working to make the required changes.

@rishiraj rishiraj changed the title add wandb integration to text, image classification & LLM finetuning add experiment tracking integration to text, image classification & LLM finetuning Oct 18, 2023
@rishiraj
Copy link
Contributor Author

Thanks for the PR. Eventually, multiple logging should be supported. Currently, we already have tensorboard. In order to get this PR merged, we need to change how the API works. The CLI should have a --log argument which can take inputs like tensorboard and wandb. --log wandb should log to wandb and so on. if nothing is provided, no logging. please let me know if the requirements are unclear

@abhishekkrthakur Made the changes you requested and successfully integrated all experiment trackers like "azure_ml", "clearml", "codecarbon", "comet_ml", "dagshub", "flyte", "mlflow", "neptune", "tensorboard", and "wandb" with LLM Finetuning, text & image classification via the --log argument. Tests are passing. Here is a notebook I used to test: https://colab.research.google.com/drive/1m0KZzcCuKRn3Rkff32XTvdIfD45hK2Va?usp=sharing

@abhishekkrthakur
Copy link
Member

Please also run: make style && make quality

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 22, 2023

The documentation is not available anymore as the PR was closed or merged.

@abhishekkrthakur abhishekkrthakur merged commit 8878930 into huggingface:main Oct 22, 2023
2 of 3 checks passed
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants