-
Notifications
You must be signed in to change notification settings - Fork 1
Issues: hubmapconsortium/py-hubmap-dbgap
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Author
Label
Projects
Milestones
Assignee
Sort
Issues list
Upload Jupyter Notebooks
documentation
Improvements or additions to documentation
enhancement
New feature or request
#12
opened Aug 11, 2023 by
icaoberg
Deploy Improvements or additions to documentation
Aspera Connect
in Singularity
documentation
#11
opened Aug 11, 2023 by
icaoberg
I renew my [previous comment](https://github.com/hubmapconsortium/py-hubmap-dbgap/pull/4#discussion_r1187602356) about the potential for KeyErrors using this pattern, either occurring in the traversal of
metadata
or when extracting the value from the {"Illumina": "ILLUMINA"}
dict.
#7
opened May 11, 2023 by
icaoberg
Additionally/alternatively, breaking out the this part where you parse the JSON entirely might be desirable. E.g. you could instead deserialize the JSON into a dataclass ([example](https://stackoverflow.com/a/76103446)) which you instantiate and refer to in the
submission
function. That should break things up, add some clarity, and help more safely retrieve values from the JSON.
#6
opened May 11, 2023 by
icaoberg
ProTip!
Follow long discussions with comments:>50.