-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make modbus retry fast on read errors #99576
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
bugfix
cla-signed
integration: modbus
small-pr
PRs with less than 30 lines.
by-code-owner
Quality Scale: gold
labels
Sep 4, 2023
Hey there @adamchengtkc, @vzahradnik, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
janiversen
force-pushed
the
call_second
branch
3 times, most recently
from
September 4, 2023 13:53
20dd816
to
47945e0
Compare
janiversen
force-pushed
the
call_second
branch
from
September 4, 2023 15:25
47945e0
to
4f27db9
Compare
MartinHjelmare
changed the title
modbus fast retry on read errors.
Make modbus retry fast on read errors
Sep 4, 2023
balloob
reviewed
Sep 12, 2023
balloob
reviewed
Sep 12, 2023
balloob
reviewed
Sep 12, 2023
janiversen
force-pushed
the
call_second
branch
from
September 12, 2023 06:48
4f27db9
to
ddfdbd3
Compare
@balloob thanks for the review, I lacked coffee when making those changes :-) |
balloob
approved these changes
Sep 12, 2023
balloob
pushed a commit
that referenced
this pull request
Sep 12, 2023
* Fast retry on read errors. * Review comments.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
bugfix
by-code-owner
cherry-picked
cla-signed
integration: modbus
Quality Scale: gold
small-pr
PRs with less than 30 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
When a read error passed, the sensor was not read until next scan interval which could be hours, now the retry is 1 second,
the number of retries is lazy_error_count.
Type of change
Additional information
Modbus failing after upgrade to 2023.9.0 #99784 at least potentially,
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: