Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make modbus retry fast on read errors #99576

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

janiversen
Copy link
Member

@janiversen janiversen commented Sep 4, 2023

Breaking change

Proposed change

When a read error passed, the sensor was not read until next scan interval which could be hours, now the retry is 1 second,
the number of retries is lazy_error_count.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Sep 4, 2023

Hey there @adamchengtkc, @vzahradnik, mind taking a look at this pull request as it has been labeled with an integration (modbus) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of modbus can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign modbus Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@janiversen janiversen marked this pull request as draft September 4, 2023 10:36
@janiversen janiversen force-pushed the call_second branch 3 times, most recently from 20dd816 to 47945e0 Compare September 4, 2023 13:53
@janiversen janiversen marked this pull request as ready for review September 4, 2023 14:09
@MartinHjelmare MartinHjelmare changed the title modbus fast retry on read errors. Make modbus retry fast on read errors Sep 4, 2023
@janiversen janiversen added this to the 2023.9.1 milestone Sep 6, 2023
@bramkragten bramkragten modified the milestones: 2023.9.1, 2023.9.2 Sep 8, 2023
@janiversen janiversen requested a review from joostlek September 10, 2023 13:26
@janiversen
Copy link
Member Author

@balloob thanks for the review, I lacked coffee when making those changes :-)

@balloob balloob merged commit 9acca1b into home-assistant:dev Sep 12, 2023
31 checks passed
@janiversen janiversen deleted the call_second branch September 12, 2023 14:57
balloob pushed a commit that referenced this pull request Sep 12, 2023
* Fast retry on read errors.

* Review comments.
@balloob balloob mentioned this pull request Sep 12, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants