Review comments.

home-assistant · Sep 12, 2023 · ddfdbd3 · ddfdbd3
1 parent 9d231a0
commit ddfdbd3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/homeassistant/components/modbus/base_platform.py b/homeassistant/components/modbus/base_platform.py
@@ -115,7 +115,9 @@ async def async_update(self, now: datetime | None = None) -> None:
     def async_run(self) -> None:
         """Remote start entity."""
         self.async_hold(update=False)
-        async_call_later(self.hass, timedelta(milliseconds=100), self.async_update)
+        self._cancel_call = async_call_later(
+            self.hass, timedelta(milliseconds=100), self.async_update
+        )
         if self._scan_interval > 0:
             self._cancel_timer = async_track_time_interval(
                 self.hass, self.async_update, timedelta(seconds=self._scan_interval)

diff --git a/homeassistant/components/modbus/sensor.py b/homeassistant/components/modbus/sensor.py
@@ -107,13 +107,16 @@ async def async_update(self, now: datetime | None = None) -> None:
         """Update the state of the sensor."""
         # remark "now" is a dummy parameter to avoid problems with
         # async_track_time_interval
+        self._cancel_call = None
         raw_result = await self._hub.async_pb_call(
             self._slave, self._address, self._count, self._input_type
         )
         if raw_result is None:
             if self._lazy_errors:
                 self._lazy_errors -= 1
-                async_call_later(self.hass, timedelta(seconds=1), self.async_update)
+                self._cancel_call = async_call_later(
+                    self.hass, timedelta(seconds=1), self.async_update
+                )
                 return
             self._lazy_errors = self._lazy_error_count
             self._attr_available = False