Skip to content
This repository has been archived by the owner on Nov 15, 2024. It is now read-only.

NFR: Sync from upstream #695 #26

Merged
merged 297 commits into from
Aug 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
297 commits
Select commit Hold shift + click to select a range
406f3bf
change url and sharepoint to upstream urls
cogniSyb Nov 22, 2023
21e3524
Inpage navigation is in reversed order on Firefox #173 (#178)
cogniSyb Nov 27, 2023
976bfd5
Hero V2 Block displays different images for mobile and desktop. #106 …
cogniSyb Nov 28, 2023
8319bb0
483 configure footer
Lakshmishri Oct 27, 2023
2d95815
498, 496 wire up prod url and refresh date api
Lakshmishri Nov 20, 2023
e3eb843
custom header resolve conflicts
Lakshmishri Nov 21, 2023
18d1851
use icon for laoding arrow-right
Lakshmishri Nov 21, 2023
b21cf38
fix PSI
Lakshmishri Nov 29, 2023
7494e7e
Merge pull request #518 from hlxsites/483-hf-config
Lakshmishri Nov 30, 2023
0b190a4
Icon cards block (#181)
SantiagoHomps-NC Nov 30, 2023
538abb7
Update feed.xml
synox Dec 5, 2023
8cee006
Add assets sidekick plugin
Dec 8, 2023
129c7d0
Merge pull request #533 from hlxsites/assets-plugin
manuel-vara Dec 11, 2023
7566669
The pop-up of the video displayed clicking on the Play video button i…
TomaszDziezykNetcentric Dec 11, 2023
af203da
Merge pull request #535 from Netcentric/release-3
cogniSyb Dec 12, 2023
e5dccaf
Update feed.xml
synox Dec 13, 2023
bec7f0f
iPhone/iPad - Icon Cards - The local video in the video pop-up cannot…
taimurCognizant Dec 15, 2023
a950f8f
fix header not loading for recall page
Lakshmishri Dec 18, 2023
7e17828
Merge pull request #541 from hlxsites/537-nhtsa-fix-header
Lakshmishri Dec 18, 2023
aa72ddd
add recalls date since for zero recalls vin look up
Lakshmishri Dec 18, 2023
e4b66c7
Update feed.xml
synox Dec 19, 2023
39550a6
Merge branch 'main' into nhtsa-recalls-date
Lakshmishri Dec 19, 2023
afbb3a6
Merge pull request #543 from hlxsites/nhtsa-recalls-date
Lakshmishri Dec 19, 2023
d398c8d
Opening up Images will display an incorrect default state on the Imag…
TomaszDziezykNetcentric Jan 3, 2024
2bf83fc
Add make, model,model-year (#546)
Lakshmishri Jan 4, 2024
9b0659d
Merge main from mack main repo
Lakshmishri Jan 5, 2024
4a8c283
Dealer locator issues (#544)
SantiagoHomps-NC Jan 8, 2024
b8854af
Hero variant for Solutions page #45 (#197)
SantiagoHomps-NC Jan 10, 2024
21d2ccc
Tabbed Carousel variant for wheelbase #190 (#196)
Lakshmishri Jan 10, 2024
c47c28f
Pencil Promo block #108 (#195)
markovukiceviccn Jan 11, 2024
0749ee2
fix alignment, add hover and focus state
cogniSyb Jan 15, 2024
33fb34a
Fix case conversion (#552)
Lakshmishri Jan 15, 2024
cd88cf9
V2 Columns Block variation #133 (#186)
SantiagoHomps-NC Jan 17, 2024
b6f41c3
Add "My Assets" functionality #201 (#202)
cogniSyb Jan 18, 2024
d6c4bd3
Update feed.xml
aem-code-sync[bot] Jan 19, 2024
56f8f6e
Update feed.xml
aem-code-sync[bot] Jan 19, 2024
1a523da
Update feed.xml
aem-code-sync[bot] Jan 19, 2024
0bcfe91
Powertrain V2 Slider Block #147 (#200)
SantiagoHomps-NC Jan 22, 2024
1eceb76
#529 icon fix for features page in mobile view (#556)
jonatan-lledo-netcentric Jan 29, 2024
f5abc76
Merge remote-tracking branch 'upstream/main'
manuel-vara Jan 30, 2024
061e666
Merge branch 'main' into develop
manuel-vara Jan 31, 2024
a9933c7
Redesign release 4 (#559)
manuel-vara Jan 31, 2024
8bdd46f
Update feed.xml
aem-code-sync[bot] Jan 31, 2024
0567730
Dealer Locator API calls reduction (#555)
SantiagoHomps-NC Feb 5, 2024
eb48157
Half grey columns variant #136 (#205)
cogniSyb Feb 6, 2024
1dda3b5
Update feed.xml
aem-code-sync[bot] Feb 10, 2024
48e03e4
Update feed.xml
synox Feb 11, 2024
c543ce0
Media with content block #140 (#210)
SantiagoHomps-NC Feb 13, 2024
636c424
Breadcrumbs #44 (#213)
jonatan-lledo-netcentric Feb 15, 2024
7fad9e9
Accordion column block #114 (#203)
jonatan-lledo-netcentric Feb 15, 2024
4efad8d
Adding Engagement tracking script (#573)
SantiagoHomps-NC Feb 21, 2024
02b1448
Update feed.xml
aem-code-sync[bot] Feb 21, 2024
7af4868
Update feed.xml
aem-code-sync[bot] Feb 22, 2024
5280b43
Alignment issues media with content block #216 (#217)
SantiagoHomps-NC Feb 26, 2024
2218108
Resources block #126 (#212)
SantiagoHomps-NC Feb 26, 2024
1b5df6d
Update feed.xml
aem-code-sync[bot] Feb 26, 2024
b7faa16
Update feed.xml
aem-code-sync[bot] Feb 26, 2024
dcdcbbf
Merge branch 'develop'
cogniSyb Feb 26, 2024
76eb46b
change url and sharepoint to upstream urls
cogniSyb Feb 26, 2024
51c759d
Redesign release 5
cogniSyb Feb 26, 2024
b1e3375
Update feed.xml
aem-code-sync[bot] Feb 26, 2024
b7fc7f6
Update feed.xml
aem-code-sync[bot] Feb 27, 2024
c0c8b96
Create bug_report.yml
cogniSyb Feb 28, 2024
0e69dcf
fix regression #626 (#627)
cogniSyb Feb 28, 2024
6422844
Create enforce-branch-policy
cogniSyb Feb 28, 2024
2bb1f41
Update feed.xml
aem-code-sync[bot] Feb 29, 2024
092c6ca
Update bug_report.yml
cogniSyb Mar 1, 2024
5390eb2
Update feed.xml
aem-code-sync[bot] Mar 4, 2024
14b014b
Bulldog Magazine "Subscribe to Magazine" Anchor Link Button Functiona…
SantiagoHomps-NC Mar 5, 2024
9847823
disable hero autoblock functionality on redesign pages (#631)
cogniSyb Mar 5, 2024
5392466
Update feed.xml
aem-code-sync[bot] Mar 6, 2024
1a2b281
Update feed.xml
synox Mar 6, 2024
ee08ae2
refactor color usage (#634)
cogniSyb Mar 6, 2024
dfcf2ff
Update feed.xml
synox Mar 7, 2024
93c3975
fix section background
cogniSyb Mar 7, 2024
80f6959
refactor alignment, add consistency, reuse code
cogniSyb Mar 8, 2024
8055acb
escape HTML to prevent XSS issue (#637)
cogniSyb Mar 8, 2024
fac7ffe
Create technical-debt.yml
cogniSyb Mar 8, 2024
0f79bc2
remove nav- pages from search
Mar 12, 2024
7af957c
Deploy new form handler code on Footer for Subscribe Box #561 (#616)
jonatan-lledo-netcentric Mar 12, 2024
e87ccf4
fix search on mobile (#635)
cogniSyb Mar 12, 2024
83a84fc
Merge pull request #642 from hlxsites/develop
cogniSyb Mar 12, 2024
e3b410c
block done
santi-homps Mar 12, 2024
f43235b
refactor styles
santi-homps Mar 12, 2024
b9f86a1
button margins
santi-homps Mar 12, 2024
191c990
margin change
santi-homps Mar 12, 2024
cba8de5
Merge pull request #643 from hlxsites/560-bug-hidden-pages-with-nofollow
netmanito Mar 12, 2024
ded0676
Update feed.xml
aem-code-sync[bot] Mar 12, 2024
50e091b
Merge branch 'develop' into 581-intro-section
SantiagoHomps-NC Mar 13, 2024
6b60f50
add nav exclusions on search
Mar 13, 2024
e8af66e
Merge pull request #646 from hlxsites/645-remove-nav-files-from-search
netmanito Mar 13, 2024
e7f0187
comments 1
santi-homps Mar 14, 2024
7e0aa0f
last comments addressed
santi-homps Mar 14, 2024
3eccd82
Add new V2 Embed block (#651)
cogniSyb Mar 15, 2024
d93fcc8
Update feed.xml
synox Mar 19, 2024
22e0500
V2 Truck Builder #578 (#632)
SantiagoHomps-NC Mar 19, 2024
f287356
575 remove capitalising of text (#641)
Lakshmishri Mar 21, 2024
db28414
Merge branch 'develop' into 581-intro-section
Lakshmishri Mar 21, 2024
8719e4d
Merge pull request #644 from hlxsites/581-intro-section
jonatan-lledo-netcentric Mar 21, 2024
9f6c5a4
add logo to sprite
cogniSyb Mar 25, 2024
3f52a63
Add files via upload
Varunvolvo Mar 26, 2024
a1d81ab
Merge pull request #666 from hlxsites/develop
cogniSyb Mar 26, 2024
09fad1a
Merge pull request #667 from hlxsites/Varunvolvo-patch-1
cogniSyb Mar 26, 2024
1fcd044
fix items not rendering in header when content is missing (#672)
cogniSyb Apr 2, 2024
c1c190c
Custom header disables menu on mobile #670 (#673)
cogniSyb Apr 3, 2024
7cc0d08
V2 Embed – Configuration #650 (#665)
cogniSyb Apr 3, 2024
1562570
Add files via upload
Varunvolvo Apr 2, 2024
13d560b
Merge pull request #674 from hlxsites/Varunvolvo-patch-1
Varunvolvo Apr 3, 2024
61942a4
Merge branch 'main' into develop
cogniSyb Apr 3, 2024
4436467
Fixes and refactoring of v2-testimonial (#677)
cogniSyb Apr 4, 2024
d1a4649
add configuration file for truck configurator
cogniSyb Apr 4, 2024
eaa5d6f
Magazine fixes #654, #655, #656 (#671)
Lakshmishri Apr 5, 2024
d55548e
Merge pull request #683 from hlxsites/develop
cogniSyb Apr 9, 2024
36dd60e
fix display of icon in v2-accordion
cogniSyb Apr 9, 2024
f14610b
fix link in footer on domains other than macktrucks.com
cogniSyb Apr 9, 2024
152568d
fix for Embed block
cogniSyb Apr 9, 2024
155e4f1
Fix rendering of Footer on non-redesign pages
cogniSyb Apr 9, 2024
7488d4d
fix #657 only show subscribeContent when it’s defined
cogniSyb Apr 9, 2024
5bb4982
check if an active campaign is running or OneTrust needs scan the act…
cogniSyb Apr 9, 2024
0fd18f9
V2 Embed performance issues #686 (#687)
cogniSyb Apr 11, 2024
1057f34
Add assets-selector config for customized embed block usage of AEM As…
actinium15 Apr 15, 2024
5b69b59
fix icon (#690)
cogniSyb Apr 16, 2024
70484c8
Add V2 Hotspots Block (#653)
SantiagoHomps-NC Apr 17, 2024
fce0223
V2 Columns block 'icon list' variant #628 (#679)
SantiagoHomps-NC Apr 18, 2024
9fc998a
Add Github issue template
cogniSyb Apr 18, 2024
59d4092
Navigation Hub #597 (#682)
jonatan-lledo-netcentric Apr 22, 2024
c7276d0
V2 Hero block "Half-height" variant #596 (#694)
SantiagoHomps-NC Apr 22, 2024
02102ed
'3-links' Columns block variant #582 (#692)
SantiagoHomps-NC Apr 22, 2024
c5bdd61
fix loading state of v2-page-navigation
cogniSyb Apr 22, 2024
21054e5
fix hover state of button
cogniSyb Apr 22, 2024
8e21efb
fix alignment on page
cogniSyb Apr 22, 2024
4444c31
fix rendering of section background image
cogniSyb Apr 22, 2024
0139103
Merge pull request #696 from hlxsites/develop
jonatan-lledo-netcentric Apr 23, 2024
4e7f835
V2 Product Listing Block #580 (#693)
Lakshmishri Apr 24, 2024
132c981
Update feed.xml
synox Apr 25, 2024
84121c2
Update feed.xml
aem-code-sync[bot] Apr 25, 2024
8580e00
Update v1 columns block to handle left images setup
cogniSyb Apr 29, 2024
45ba17b
Update feed.xml
aem-code-sync[bot] Apr 30, 2024
db449af
Truck Configurator embed #591 (#647)
cogniSyb May 1, 2024
23bfc51
Update feed.xml
aem-code-sync[bot] May 2, 2024
caa4dd9
Update feed.xml
aem-code-sync[bot] May 2, 2024
ef5abb2
fix duplicate icons in sprite (#703)
cogniSyb May 3, 2024
aa4c721
Performance Specifications #90 (#691)
jonatan-lledo-netcentric May 3, 2024
42b38bf
Update feed.xml
aem-code-sync[bot] May 6, 2024
d843cc8
Display the search & login icon in Header on development/test environ…
jonatan-lledo-netcentric May 7, 2024
2ff71dc
Merge pull request #707 from hlxsites/develop
cogniSyb May 7, 2024
61a53c9
exclude files from index
cogniSyb May 7, 2024
e01e0a0
Update feed.xml
aem-code-sync[bot] May 7, 2024
d119cd4
exclude files from index
cogniSyb May 8, 2024
a612198
fix #708; don't execute code if head isn't available
cogniSyb May 8, 2024
52c2b40
Merge pull request #709 from hlxsites/708-fragment-block
cogniSyb May 8, 2024
3d97234
Update feed.xml
synox May 9, 2024
e8a4487
Disable Cookies in Pre-Prod for Helix-v5 Upgrade #698 (#705)
cogniSyb May 9, 2024
4633eae
V2 Columns block - inset variant #619 (#710)
santi-homps May 16, 2024
abc8d69
Update DL endpoint to POD #440 (#685)
SantiagoHomps-NC May 16, 2024
890f4e8
Update feed.xml
synox May 17, 2024
4008853
fix syntax error with inpage navigation
cogniSyb May 10, 2024
37c73e9
fix regression for recalls
cogniSyb May 21, 2024
78196cb
404 Page Localization Primary Markets #711 (#712)
amglebihan May 21, 2024
8daa0a4
Merge branch 'main' into develop
cogniSyb May 21, 2024
ef17ab5
fix button appearance in v2-truck-builder
cogniSyb May 21, 2024
45298bd
Merge pull request #715 from hlxsites/develop
cogniSyb May 21, 2024
076c374
Update feed.xml
aem-code-sync[bot] May 22, 2024
69d8e06
Update feed.xml
aem-code-sync[bot] May 22, 2024
1665c36
Update feed.xml
aem-code-sync[bot] May 22, 2024
9f0ee7a
Update feed.xml
aem-code-sync[bot] May 22, 2024
dc336b3
Scripts configs moved to sharepoint #663 (#720)
santi-homps May 27, 2024
4ce6434
Add custom decorateIcons script for helix v5 #704 (#716)
cogniSyb May 27, 2024
eff25dd
date added to query yaml (#722)
santi-homps May 27, 2024
dc995be
fix header, regression
cogniSyb May 28, 2024
edccf34
Magazine date, new var name (#724)
santi-homps May 28, 2024
9d9dd26
Magazine date (#725)
santi-homps May 28, 2024
467a7d2
Remove deprecated block v2-all-trucks (#727)
cogniSyb May 29, 2024
a560b1b
add missing config scripts
cogniSyb May 29, 2024
6c0c8aa
fix list items
cogniSyb May 29, 2024
e2108b2
fix alignment
cogniSyb May 29, 2024
511a307
Refactoring Buttons for Helix 5 Upgrade #713 (#719)
amglebihan May 30, 2024
9b4bd6a
Magazine date format #431 (#726)
santi-homps May 30, 2024
76d158f
Update feed.xml
aem-code-sync[bot] May 30, 2024
edfce20
fix v2-hero height when v2-breadcrumb is present #732
cogniSyb May 31, 2024
26f6768
make motion custom properties available to v1-pages
cogniSyb May 31, 2024
a5c82d2
Sub-navigation block for Bulldog Magazine #599 (#728)
amglebihan Jun 3, 2024
749ab6b
Refactor loading of Truck Configurator URLs #717 (#734)
cogniSyb Jun 3, 2024
00acfcd
Update feed.xml
synox Jun 4, 2024
115fca1
Restore V1 buttons #713 (#731)
cogniSyb Jun 4, 2024
e579cd8
Merge branch 'main' into develop
amglebihan Jun 4, 2024
c6b1442
Add missing bracket in styles.css
amglebihan Jun 4, 2024
662f085
Add missing comma in styles.css
amglebihan Jun 4, 2024
022ebc5
fix v2-hero no-image variant #732
cogniSyb Jun 5, 2024
793c756
add support for marketing cta button #713
cogniSyb Jun 5, 2024
663745d
Merge pull request #736 from hlxsites/develop
amglebihan Jun 5, 2024
315b016
Magazine date fix (#739)
santi-homps Jun 6, 2024
01641b8
FR: video in hero #589 (#737)
amglebihan Jun 13, 2024
f168ebb
Fix URL of teaser-grid (#744)
cogniSyb Jun 17, 2024
806dbc8
Magazine Tabbed Carousel with autoscroll #604 (#740)
santi-homps Jun 17, 2024
f09cd39
Merge pull request #755 from hlxsites/develop
amglebihan Jun 18, 2024
6d2ada6
Add patch files for market sites
cogniSyb Jun 18, 2024
1ea8893
Update feed.xml
aem-code-sync[bot] Jun 18, 2024
a262474
Add configuration for Venezuela
cogniSyb Jun 18, 2024
aa7efdd
Create add-version.yaml
cogniSyb Jun 18, 2024
9dd680d
Update package version to main
Jun 18, 2024
099699e
Update package version
cogniSyb Jun 18, 2024
8af5f6b
Create update-package-version.yaml
cogniSyb Jun 18, 2024
79bf19f
Constants file content checks added (#756)
santi-homps Jun 19, 2024
82c8fa6
Merge branch 'main' into develop
amglebihan Jun 19, 2024
1c6246b
Merge constants check into main (#758)
santi-homps Jun 20, 2024
b7bc6ec
Add configuration for Museum
cogniSyb Jun 18, 2024
a3c36be
Update update-package-version.yaml
cogniSyb Jun 20, 2024
1e543b7
Remove 'v' prefix to fix linting
cogniSyb Jun 20, 2024
9589cd2
Add configuration for Museum
cogniSyb Jun 18, 2024
d1256b3
Update update-package-version.yaml
cogniSyb Jun 20, 2024
639ce78
Remove 'v' prefix to fix linting
cogniSyb Jun 20, 2024
8565607
Add GitHub actions to handle the package.json version
amglebihan Jun 25, 2024
932b1de
Revert changes made to run-tests.yaml
amglebihan Jun 25, 2024
b0031f5
Video in modal broken #763 (#764)
amglebihan Jun 25, 2024
a09fb9f
Merge branch 'main' into develop
amglebihan Jun 25, 2024
863ec7e
Magazine Tabbed Carousel - Video #607 (#757)
amglebihan Jun 25, 2024
e60cd23
collage grid style #605 (#741)
jonatan-lledo-netcentric Jun 25, 2024
2d0d6a9
Update feed.xml
aem-code-sync[bot] Jun 27, 2024
07672c4
fix truck-lineup #751 (#768)
jonatan-lledo-netcentric Jul 1, 2024
dd9f7c7
add specific styles for with-dots variant & a bit of clean up
jonatan-lledo-netcentric Jul 2, 2024
3435d3c
v5 aem.js loadCSS returns a promise (#782)
jonatan-lledo-netcentric Jul 2, 2024
01f02eb
4 row v2-cards variant #593 (#765)
jonatan-lledo-netcentric Jul 2, 2024
14c6e3a
placeholder file sync
jonatan-lledo-netcentric Jul 2, 2024
d5da487
sync constants json file
jonatan-lledo-netcentric Jul 2, 2024
6740aee
Merge branch 'main' into develop
jonatan-lledo-netcentric Jul 2, 2024
4dec47d
remove some trailing spaces
jonatan-lledo-netcentric Jul 2, 2024
186cb69
Merge pull request #786 from hlxsites/develop
jonatan-lledo-netcentric Jul 2, 2024
8feaad1
Update feed.xml
aem-code-sync[bot] Jul 2, 2024
3d0883d
Merge branch 'develop' into 779-product-listing-padding
jonatan-lledo-netcentric Jul 3, 2024
878d2fa
version update
jonatan-lledo-netcentric Jul 3, 2024
bbf9e59
update styles to match figma #779
jonatan-lledo-netcentric Jul 3, 2024
6457230
small style adjustments to better design matching #779
jonatan-lledo-netcentric Jul 4, 2024
66e5aeb
update gap values by removing magic numbers #779
jonatan-lledo-netcentric Jul 5, 2024
68f45f5
Fix block overlap #780
alexiscoelhonc Jul 5, 2024
994c494
style issues & font sizes fix #799
jonatan-lledo-netcentric Jul 5, 2024
9e9cfd7
Fix product listing mobile dots variant #779
alexiscoelhonc Jul 8, 2024
c70a600
Fix image size #779
alexiscoelhonc Jul 8, 2024
2bb42c6
Fix image ratio #779
alexiscoelhonc Jul 8, 2024
78edd05
Merge pull request #787 from hlxsites/780-fix-block-overlap
alexiscoelho Jul 9, 2024
5f247f1
V2 embed video broken #795 (#796)
amglebihan Jul 15, 2024
4b17a6c
Merge pull request #785 from hlxsites/779-product-listing-padding
alexiscoelho Jul 15, 2024
9ba2877
Merge branch 'main' into develop
alexiscoelhonc Jul 16, 2024
8483e36
Release 21 - Update package.json version
alexiscoelhonc Jul 16, 2024
7d758d7
Release 3 - Remove unnecessary code
alexiscoelhonc Jul 16, 2024
5ebaac8
Merge pull request #801 from hlxsites/release-21
alexiscoelho Jul 16, 2024
4ea03c4
Update feed.xml
synox Jul 19, 2024
e104b74
Update feed.xml
aem-code-sync[bot] Jul 22, 2024
a5403c5
Merge branch 'main' of github.com:hlxsites/vg-macktrucks-com into 695…
amglebihan Jul 25, 2024
a10b70a
Fix market name and linting errors
amglebihan Jul 25, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
helix-importer-ui
common/echarts-5.4.2
vendor/**
118 changes: 118 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,118 @@
name: 'Report 🐛 bug or 🕳️ defect'
description: Please fill out this form to report a bug or defect.
labels: ["Bugfix, Triage"]
projects: ["hlxsites/8"]
body:
- type: dropdown
id: issue-type
attributes:
label: Issue Type
description: >
Select whether this is a bug or a defect.

<details>

<summary>What’s the difference?</summary>


:hole: **Defects**

These are issues that are found when testing a functional requirement or change request.


:bug: **Bugs**

Bugs are issues that are found when not validating any Change Request or Functional requirement. They can be regressions or simply issues you find while doing Exploratory Testing.
</details>
options:
- Bug
- Defect
validations:
required: true
- type: input
id: summary
attributes:
label: Summary
description: Provide a short description of the defect. Include the block name
or story in brackets for easier search.
placeholder: e.g., [Block Name] Issue description.
validations:
required: false
- type: dropdown
id: priority
attributes:
label: Priority
description: Select the priority of the issue.
options:
- Blocker
- Critical
- High
- Medium
- Low
validations:
required: true
- type: textarea
id: description
attributes:
label: Description
description: Provide a more detailed description of the issue.
placeholder: Detailed issue description here.
validations:
required: true
- type: dropdown
id: affected-device-classes
attributes:
label: Affected Device Classes
description: Check all device classes affected by this issue.
multiple: true
options:
- Mobile
- Tablet
- Desktop
validations:
required: true
- type: textarea
id: affected-browsers-devices
attributes:
label: Affected Browsers/Devices and Versions
description: List all browsers and devices affected by this issue and specify
their versions.
placeholder: e.g., Chrome (v123), Safari (on iOS 17.4)
validations:
required: true
- type: textarea
id: steps-to-reproduce
attributes:
label: Steps to Reproduce
description: Detail the steps to reproduce the bug. Each action should be a
separate step.
placeholder: |-
1. Navigate to…
2. Click on…
3. Observe the issue.
validations:
required: true
- type: textarea
id: expected-results
attributes:
label: Expected Results
description: Describe the correct behavior expected. Include links to
specifications if available.
placeholder: Expected behavior description.
validations:
required: true
- type: textarea
id: actual-results
attributes:
label: Actual Results
description: Describe the defect identified.
placeholder: Actual defect description.
validations:
required: true
- type: textarea
attributes:
label: Attachment
description: You can attach images by clicking this area and drag files in.
placeholder: Upload file
validations:
required: false
98 changes: 98 additions & 0 deletions .github/ISSUE_TEMPLATE/new_feature.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,98 @@
name: 'New feature ✨'
description: Functional or non-functional requirements
body:
- type: markdown
attributes:
value: >-
Naming convention:

- For functional requirements: FR: [block name] - &lt;issue description&gt;

- For non-functional requirements: NFR: &lt;issue description&gt;
- type: textarea
id: description
attributes:
label: Context/Description
description: >-
This section contains information from the business like:

- Business needs

- User Stories

- Design
validations:
required: true
- type: textarea
id: acceptance-criteria
attributes:
label: Acceptance Criteria
description: >
<details>

<summary>Examples</summary>


User AC:

- Users can see in some flyout additional teaser areas (including titles) on top or below the navigation list

- In the teaser areas 1-n teasers are visible

- To meet a11y criteria, do not forget about alt text for teaser image


Editor AC:

- The current situation needs to be the default

- Teasers including section title can be added on specific flyouts, on top or below the navigation list

- New configurations should only be available in Mack Trucks


Non-functional AC:

- Performance

- Accessibility

- href in sitemap
</details>
value: |+
**User AC:**


**Editor AC:**


**Non-functional AC:**

validations:
required: true
- type: textarea
id: out-of-scope
attributes:
label: Out of scope
description: >-
List of things that are not in scope. For instance when a ticket is
split or a certain function is deprioritized.
- type: textarea
id: note
attributes:
label: Note
description: Some additional information that can help the implementation or testing.
- type: textarea
id: technical-details
attributes:
label: Technical details
description: >-
In case a certain technical direction is chosen it can be added here.
Can happen as follow up of a spike for instance.
- type: textarea
attributes:
label: Attachment / link to Figma
description: You can attach images by clicking this area and drag files in, or add a URL.
placeholder: Upload file or paste URL
validations:
required: false
113 changes: 113 additions & 0 deletions .github/ISSUE_TEMPLATE/technical-debt.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,113 @@
name: 'File technical debt ⚓️'
description: Please fill out this form to file technical debt.
labels: ["Technical debt, Triage"]
projects: ["hlxsites/8"]
body:
- type: input
id: summary
attributes:
label: Summary
description: Provide a short description and include a block name or story in brackets for easier search.
placeholder: e.g., [Block Name] Issue description.
validations:
required: false
- type: dropdown
id: priority
attributes:
label: Priority
description: Select the priority of the issue.
options:
- Blocker
- Critical
- High
- Medium
- Low
default: 3
validations:
required: true
- type: textarea
id: description
attributes:
label: Description
description: Provide a more detailed description of the issue.
placeholder: Detailed issue description here.
validations:
required: true
- type: dropdown
id: value
attributes:
label: Value creation
description: Check all possible outcomes that apply.
multiple: true
options:
- Performance improvement
- Maintainability & scalability
- Compliance & standards
- DX improvement
- UX improvement
- EX improvement
validations:
required: true
- type: dropdown
id: cost-of-fixing
attributes:
label: Cost of fixing
description: >
Categorize the cost of fixing technical debt items, considering both immediate and long-term perspectives

<details>

<summary>Details of perspectives</summary>


**Low Cost**

- Immediate: Requires minimal effort, such as minor code refactoring or updating documentation. Can often be addressed by a single developer in a few hours or less.
- Long-Term: Neglecting these might slightly degrade code quality over time but won't likely cause significant issues in the short term.

**Medium Cost**

- Immediate: Involves moderate effort, such as optimizing existing algorithms, implementing better error handling, or updating several dependencies. May require a few days of work and potentially a small team to ensure thorough testing and integration.
- Long-Term: If left unaddressed, could lead to moderate performance issues, hinder scalability, or increase maintenance time and costs.

**High Cost**

- Immediate: Demands substantial effort, such as rewriting a significant portion of the codebase, migrating to a new framework, or addressing complex security vulnerabilities. This could involve multiple team members over weeks or months, with considerable testing and validation phases.
- Long-Term: Ignoring these issues can lead to severe performance bottlenecks, security breaches, legal compliance issues, or major disruptions in user experience, potentially costing much more in damage repair, lost customers, or legal penalties.

**Variable Cost**

- Immediate: The cost is dependent on the chosen approach, such as deciding between patching a system for a temporary fix versus investing in a more comprehensive solution that may take longer initially but provides greater benefits in the long run.
- Long-Term: A strategic decision to invest more upfront can significantly reduce future costs related to maintenance, scalability, and performance optimization.
</details>
options:
- Low cost
- Medium cost
- High cost
- Variable cost
default: 0
validations:
required: true
- type: dropdown
id: technical-complexity
attributes:
label: Technical complexity
description: The level of technical challenge involved in fixing the debt.
options:
- XL
- L
- M
- S
- XS
- Unknown
default: 3
validations:
required: true
- type: textarea
id: references
attributes:
label: References
description: Links to relevant examples, discussions, PRs, or documentation that provide more context.
placeholder:
validations:
required: true
2 changes: 1 addition & 1 deletion .github/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
changelog:
exclude:
labels:
- ignore-for-release
- Ignore for release
categories:
- title: Functional requirements
labels:
Expand Down
15 changes: 15 additions & 0 deletions .github/workflows/enforce-branch-policy
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
name: Enforce Branch Policy
on:
pull_request:
branches: [main]

jobs:
check-branch:
runs-on: ubuntu-latest
steps:
- name: Check source branch
run: |
if [ "${{ github.head_ref }}" != "develop" ]; then
echo "This repository only allows merges to main from develop."
exit 1
fi
35 changes: 35 additions & 0 deletions .github/workflows/update-package-version.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
name: Update Package Version

on:
push:
tags:
- 'v*'

jobs:
update-version:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v3
with:
ref: ${{ github.head_ref }}
# The bot user https://github.com/hlx-macktrucks-bot is used to commit the changes. The personal access token
# must be created from: https://github.com/settings/tokens
# The token is then stored in the secrets of the this.
# see https://github.com/hlxsites/vg-macktrucks-com/settings/secrets/actions
token: ${{ secrets.BOT_ACCESS_TOKEN }}

- name: Update package version by release tag
uses: BellCubeDev/update-package-version-by-release-tag@v2
with:
keep-v: "false"
ignore-semver-check: "true"
encoding: "utf8"

- name: Commit and Push Changes
run: |
git config user.name "GitHubActions"
git config user.email "<>"
git add package.json
git commit -m "Update package version to ${{ github.ref_name }}"
git push
Loading
Loading