Skip to content
This repository has been archived by the owner on Nov 15, 2024. It is now read-only.

NFR: Sync from upstream #695 #26

Merged
merged 297 commits into from
Aug 5, 2024
Merged

NFR: Sync from upstream #695 #26

merged 297 commits into from
Aug 5, 2024

Conversation

amglebihan
Copy link
Collaborator

cogniSyb and others added 30 commits November 22, 2023 23:51
…centric#178)

* fix Firefox issue with sorting
* fix naming issues
* refactor focus state, button styles
* fix overlap issue
…ntric#106 (Netcentric#179)

* refactor naming structure
* refactor adaptive images mechanism
* #509 Fix displaying header on dealer page

* fix done

* one trust position ix

* Embed block match NZ one

* Update feed.xml

* Fix createElement()  v1-Cards

* Update feed.xml

* Update release.yml

* columns block adapted

* icon cards working

* css clean

* adjustements

* last changes

* specific class

* btn state styling

* comments corrected

* secondary btn margin corrected

* secondary btn class added

* cleanup

---------

Co-authored-by: Tomasz Dziezyk <[email protected]>
Co-authored-by: TomaszDziezykNetcentric <[email protected]>
Co-authored-by: Jonatan Lledo <[email protected]>
Co-authored-by: aem-code-sync[bot] <aem-code-sync[bot]@users.noreply.github.com>
Co-authored-by: Syb <[email protected]>
… be played and is incorrectly displayed Netcentric#184 (Netcentric#185)

* fix Netcentric#184: use <video> tag for video in modal
* fix modal close button
* fix override fullscreen play for safari
* refactor setting attributes
Add recalls date since for zero recalls vin look up
* add make, model,model-year

* 547 transport canada number
Merge remote-tracking branch 'upstream/main'
* href fix

* pin correctly rendered

* timezone changed

* timezone calculated

* various fixes

* new changes

* full solution implemented

* filter by type added
* hero variants added

* refactored changes to alltrucks block

* comments addressed

* color confusion

* make btn color always white

* button style refactor

* margin solved

* pdp edge cases
* add new variant for tabbed carousel
* 190 fadeIn effect with no scroll
* 190 Fix line more than 100 chars
* 190 fix index overflow
* Figcap conditional add, default color & tab items wider
* list style none & setCarousel index-1 too

---------

Co-authored-by: Jonatan Lledo <[email protected]>
* Netcentric#108 - Pencil promo and banner promo block

* Netcentric#108 - Add cursor: pointer to the block

* Netcentric#108 - Add pencil banner links styles

* Netcentric#108 - Change link hover color to acheive better contrast

* Applied comments & each block cares by itself only

* fixed alignment issue in line 288

* fix lint issue

* Fix an issue if p Element is not present inside content

* Style issues fix

* remove an unnecessary search for h1 & its styling

* move the hover effect 1 level up & a bit of code clean up

---------

Co-authored-by: Jonatan Lledo <[email protected]>
@amglebihan amglebihan requested a review from alexiscoelho July 25, 2024 14:12
Copy link

aem-code-sync bot commented Jul 25, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Jul 25, 2024

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@alexiscoelho alexiscoelho merged commit e0d8a71 into main Aug 5, 2024
2 checks passed
@alexiscoelho alexiscoelho deleted the 695-sync-from-upstream branch August 6, 2024 06:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.