Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tradeoff - Load Adobe Launch in head if cached #244

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: Tradeoff - Load Adobe Launch in head if cached #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b2d2b97
fix: Tradeoff - Load Adobe Launch in head if cached
andreituicu Apr 20, 2024
c003d67
fix: Tradeoff - Load Adobe Launch in head if cached
andreituicu Apr 20, 2024
40708a3
fix: Tradeoff - Load Adobe Launch in head if cached
andreituicu Apr 20, 2024
a17367a
Revert "fix: Tradeoff - Load Adobe Launch in head if cached"
andreituicu Apr 20, 2024
ed717a9
fix: Tradeoff - Load Adobe Launch in head if cached
andreituicu Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions aemeds/scripts/delayed.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,10 @@ import { sampleRUM } from './aem.js';
// Core Web Vitals RUM collection
sampleRUM('cwv');
// add more delayed functionality here

if (!window.sessionStorage.getItem('com.adobe.reactor.adobeLaunchCached')) {
// defined in the head of the page
// eslint-disable-next-line no-undef
loadAdobeDTM();
sessionStorage.setItem('com.adobe.reactor.adobeLaunchCached', 'true');
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be better if this was set directly from the Adobe Launch Code

}
5 changes: 4 additions & 1 deletion head.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,5 +61,8 @@
}
}

loadAdobeDTM();
// otherwise to load Adobe Launch Delayed
if (sessionStorage.getItem('com.adobe.reactor.adobeLaunchCached')) {
loadAdobeDTM();
}
</script>
Loading