fix: Tradeoff - Load Adobe Launch in head if cached #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
andreituicu
commented
Apr 20, 2024
This reverts commit 40708a3.
andreituicu
commented
Apr 22, 2024
| // defined in the head of the page | ||
| // eslint-disable-next-line no-undef | ||
| loadAdobeDTM(); | ||
| sessionStorage.setItem('com.adobe.reactor.adobeLaunchCached', 'true'); |
There was a problem hiding this comment.
it would be better if this was set directly from the Adobe Launch Code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal: Load Adobe Launch Script in the head, as long as the scripts are cached in the local browser. Otherwise, load them delayed.
We use the same approach for font loading.
Test URLs: