Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with domain is null error #389

Merged
merged 4 commits into from
Oct 3, 2023
Merged

Fix issue with domain is null error #389

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
32bfdf1
Add check for hostname and check for breadcrumb is null
lansami Oct 3, 2023
c41501c
Fix linting issues
lansami Oct 3, 2023
1c6af7e
remove breadcrumb check because is introduced in other PR
lansami Oct 3, 2023
fece388
Merge branch 'main' into issue-388
basecode Oct 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions scripts/scripts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,10 @@ function getDomainInfo(hostname) {

function pushPageLoadToDataLayer() {
const { hostname } = window.location;
if (!hostname) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect the hostname to be not null. Rather main--bitdefender--hlxsites.hlx.page?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in case of sidekick, when loading the page, the window.localtion.hostname is an empty string

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack!

return;
}

const { domain, domainPartsCount } = getDomainInfo(hostname);
const languageCountry = getLanguageCountryFromPath(window.location.pathname);
const environment = getEnvironment(hostname, languageCountry.country);
Expand Down