Fix issue with domain is null error #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
|
|
|
andreibogdan
approved these changes
Oct 3, 2023
basecode
reviewed
Oct 3, 2023
scripts/breadcrumbs.js
Outdated
| @@ -86,7 +86,7 @@ export async function loadBreadcrumbs() { | |||
| decorateBlockWithRegionId(breadcrumb, 'Hero|Breadcrumb'); | |||
|
|
|||
| // check if breadcrumb div exists | |||
| if (breadcrumb !== undefined) { | |||
| if (breadcrumb !== undefined && breadcrumb !== null) { | |||
There was a problem hiding this comment.
Can we simplify and catch all "nullish" values? -> if (breadcrumb)
There was a problem hiding this comment.
I reverted this, I saw that there is another PR that has this change
| @@ -362,6 +362,10 @@ function getDomainInfo(hostname) { | |||
|
|
|||
| function pushPageLoadToDataLayer() { | |||
| const { hostname } = window.location; | |||
| if (!hostname) { | |||
There was a problem hiding this comment.
I expect the hostname to be not null. Rather main--bitdefender--hlxsites.hlx.page?
There was a problem hiding this comment.
in case of sidekick, when loading the page, the window.localtion.hostname is an empty string
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #388
Test URLs: