forked from adobe/aem-boilerplate
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add percy integration #124
Open
dpatil-magento
wants to merge
39
commits into
develop
Choose a base branch
from
percy-demo-new
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
dcc5b46
update cypress
dpatil-magento 31b6f6f
update
dpatil-magento bff6872
update
dpatil-magento 0ea3671
update
dpatil-magento b35da53
update
dpatil-magento 8c57e75
update
dpatil-magento 21d57cd
update
dpatil-magento 335e48c
update
dpatil-magento bb290fc
update
dpatil-magento 7063664
Merge branch 'develop' into percy-demo-new
dpatil-magento 4bb784a
update
dpatil-magento 804404e
test
dpatil-magento bccf626
update
dpatil-magento 0dc6d66
update
dpatil-magento 77be458
update
dpatil-magento d293de0
update
dpatil-magento 572f8f4
fix mobile screen with percy
dpatil-magento dbd46a3
update
dpatil-magento 7d59d23
recheck
dpatil-magento be52271
check mobile view fix
dpatil-magento 674c544
update
dpatil-magento ae4104c
update
dpatil-magento 4f0390c
test
dpatil-magento 4e11e09
update
dpatil-magento d900c75
update
dpatil-magento 9168ebd
disable mobile
dpatil-magento d20bf6e
update
dpatil-magento 01d182d
avoid duplicating
dpatil-magento 098b084
update
dpatil-magento 09b5057
cleanup
dpatil-magento 220a3f0
Check stability 1
dpatil-magento 8af1fa2
Check stability 2
dpatil-magento 5eaf1c4
Merge branch 'develop' into percy-demo-new
dpatil-magento b97a8db
Merge branch 'develop' into percy-demo-new
dpatil-magento 4984a8b
fix missed conflict
dpatil-magento 8cdc92a
Merge branch 'develop' into percy-demo-new
dpatil-magento 1a19f9d
Merge branch 'develop' into percy-demo-new
dpatil-magento bd435fc
update
dpatil-magento 1d01aff
Merge branch 'develop' into percy-demo-new
dpatil-magento File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is something that can only be run on CICD? Will it gracefully fail if we run cypress locally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only the GitHub action uses percy. Locally you run cypress in your own browser via the
cypres:runcommand.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are test lines which include calls to Percy - just making sure these won't fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dev told me that these percy commands are just skipped and do not throw if you do not have the percy token. 👍🏼