add percy integration #124
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
| Cypress.on('uncaught:exception', (err, runnable) => { | ||
| return false; | ||
| }); |
There was a problem hiding this comment.
What is intent of this callback? Doesn't seem to do anything :D
| cy.visit(''); | ||
| cy.get('.nav-drop') | ||
| .contains('Catalog') | ||
| .click(); | ||
| // Randomly empty click is triggered |
There was a problem hiding this comment.
https://github.com/hlxsites/aem-boilerplate-commerce/actions/runs/11219937102/job/31187005036 guest checkout failed twice. I could see this on my local where cypress was clicking on product link too fast that empty click happened so, cypress was expecting PDP page but app is still on home page. After adding this wait, i have not reproduced it.
There was a problem hiding this comment.
I like the format for comments like `// X because Y
// adding a wait because product link is clicked too quickly
But more importantly, you could probably avoid this by waiting for some specific element that exists on pdp to appear, rather than an arbitrary wait.
cypress/src/actions/index.js
Outdated
| cy | ||
| .viewport('iphone-x') | ||
| .percySnapshot('Auth Create Account', { width: 375 }) | ||
| .viewport(1280, 1024) | ||
| .percySnapshot('Auth Create Account', { width: 1280 }); |
There was a problem hiding this comment.
Nice, maybe we should wrap this into a util function likefunction takeSnapshot(reason:string, widths: number[])?
I see you repeating this block a bit.
| command: npm run cypress:percy | ||
| env: | ||
| # pass the Percy Token | ||
| PERCY_TOKEN: ${{ secrets.PERCY_TOKEN }} |
There was a problem hiding this comment.
So this is something that can only be run on CICD? Will it gracefully fail if we run cypress locally?
There was a problem hiding this comment.
Only the GitHub action uses percy. Locally you run cypress in your own browser via the cypres:run command.
There was a problem hiding this comment.
There are test lines which include calls to Percy - just making sure these won't fail.
There was a problem hiding this comment.
Dev told me that these percy commands are just skipped and do not throw if you do not have the percy token. 👍🏼
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #
Test URLs:
Before: https://develop--aem-boilerplate-commerce--hlxsites.hlx.live/
After: https://percy-demo-new--aem-boilerplate-commerce--hlxsites.hlx.live/