Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constraint solving for function overloading #213

Merged
merged 46 commits into from
Oct 4, 2024
Merged

Constraint solving for function overloading #213

merged 46 commits into from
Oct 4, 2024

Conversation

auht
Copy link
Contributor

@auht auht commented Mar 4, 2024

No description provided.

@LPTK LPTK mentioned this pull request Mar 11, 2024
Closed
@LPTK LPTK changed the base branch from new-definition-typing to mlscript March 11, 2024 08:21
@LPTK
Copy link
Contributor

LPTK commented May 17, 2024

Do you intend to fix the bug and merge this?

@LPTK
Copy link
Contributor

LPTK commented Aug 26, 2024 •
edited
Loading

  • TODO: Guard this feature behind a flag.

LPTK
LPTK reviewed Sep 19, 2024
View reviewed changes
shared/src/test/diff/fcp/Overloads.mls Outdated Show resolved Hide resolved
shared/src/test/diff/nu/HeungTung.mls Outdated Show resolved Hide resolved
@auht auht marked this pull request as ready for review September 27, 2024 13:00
LPTK
LPTK approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@LPTK LPTK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please just address the two comments and then let me merge it.

shared/src/main/scala/mlscript/ConstraintSolver.scala Outdated Show resolved Hide resolved
shared/src/test/diff/fcp/Overloads.mls Show resolved Hide resolved
@LPTK LPTK merged commit 5841627 into hkust-taco:mlscript Oct 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LPTK LPTK LPTK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@auht @LPTK