React Testing Library Conversion #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Init react testing library
useLastLocation Tests
withLastLocation tests
JacobMGEvans
changed the title
- merged with useLastLocation -> expected behavior from user - removed Provider test file testing props and implementation details - rerender possibly not refiring Provider Co-authored-by: Braydon Hall
|
Pretty close to done. We had it at 100% at one point lol |
Provider state bleeding into next test
setLastLocation was used previously
- Moved Provider tests into useLastLocation - Tested lastLocation context Getter in rerendered test using it to check context key & pathname as well as the hook
|
Done. 100% coverage and 100% React Testing Library. We also removed the Enzyme dependencies |
100% test coverage
|
@hinok It is ready for review.
|
|
@JacobMGEvans I will take a look today evening after work, many thanks! |
|
@hinok just a friendly reminder, this PR is ready 😄 |
|
@hinok any update on this? |
|
@JacobMGEvans Many thanks 👏👏👏👏👏👏 Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read more about us: https://github.com/OpenSourceRaidGuild/tutorial-quest#hi-wave-welcome-to-the-open-source-raid-guild-crossed_swords
Our Discord server: https://discord.gg/JczjG8su
resolves #54