Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peerDependencies & testing-library for 2.0.1 in package.json are different in github from npm #65

Open
iulianraduat opened this issue Sep 3, 2021 · 7 comments

Comments

@iulianraduat
Copy link

Hi Dawid,

I am using React 17 and the peerDependencies in package.json from here (github) is including it, but the one published in npm registry no (even if they have the same 2.0.1 version).

It will be great to have a new version published in npm registry which also supports React 17 via peerDependencies.

Also you can use the bellow declaration to reduce the peerDependencies:

"peerDependencies": {
    "prop-types": "^15.6.0",
    "react": ">=15.5.4",
    "react-dom": ">=15.5.4",
    "react-router-dom": ">=4.1.1"
},

Many thanks,
Iulian

@joealden
Copy link
Contributor

joealden commented Oct 4, 2021

@hinok do you think we could get a new version published sometime soon?

I know you mentioned in #57 (comment) that you wanted to do some cleanup on the recently made changes, so I'm wondering what the status on this is, and is this what is blocking a release of 2.0.2 (or 2.1.0)?

@joealden
Copy link
Contributor

@hinok any update on the above?

@teetotum
Copy link

teetotum commented Feb 21, 2022

This poses a problem in my project now.

Addendum:
Anyone having this problem right now: you can help yourself by specifying an override for the nested outdated dependency in your package.json.
You basically tell npm to ignore the outdated dependency and use the same that your app uses.

{
  // your regular app dependencies
  "dependencies": {
    "react": "^18.0.0",
    "react-dom": "^18.0.0"
  },
  "overrides": {
    // the override can be defined as a reference to the app dependency
    "react": "$react",
    "react-dom": "$react-dom"
  }
}

@adefrutoscasado
Copy link

Having this problem too.

Cant use [email protected] with react@17.
Using NPM 8.1.2 throws an error in the install. Using previous versions of NPM ignores this problem.

npm ERR! Found: [email protected]
npm ERR! node_modules/react
npm ERR!   react@"^17.0.2" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^15.5.4 || ^16.0.0" from [email protected]

@anzarsh
Copy link

anzarsh commented Apr 20, 2022

@hinok any updates? We need a new version with updated react dependencies, please 🙏

@mturley
Copy link

mturley commented Jun 16, 2022

+1, this is now causing issues in my project as well. If there are other issues blocking a release perhaps a patch release can be made that only bumps the peerDependencies? (this change: #64)

@Stranget0
Copy link

I have forked this and fixed some of mentioned peer dep issues in https://www.npmjs.com/package/react-router-last-location-17 as I had some issues with it as well within my project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants