Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(spaces) remove "limited GA" phrasing #3106

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(spaces) remove "limited GA" phrasing #3106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fc6e0a6
Remove "limited GA" phrasing
friism Nov 20, 2024
6f00b46
update test to match
friism Nov 20, 2024
3357946
fix test
friism Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cli/src/commands/spaces/create.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export default class Create extends Command {
})
ux.action.stop()

ux.warn(`${color.bold('Spend Alert.')} During the limited GA period, each Heroku ${spaceType} Private Space costs ~${dollarAmountHourly}/hour (max ${dollarAmountMonthly}/month), pro-rated to the second.`)
ux.warn(`${color.bold('Spend Alert.')} Each Heroku ${spaceType} Private Space costs ~${dollarAmountHourly}/hour (max ${dollarAmountMonthly}/month), pro-rated to the second.`)
ux.warn(`Use ${color.cmd('heroku spaces:wait')} to track allocation.`)

ux.styledHeader(space.name)
Expand Down
4 changes: 2 additions & 2 deletions packages/cli/test/unit/commands/spaces/create.unit.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ describe('spaces:create', function () {

api.done()

expect(stderr.output).to.include('Warning: Spend Alert. During the limited GA period, each Heroku Standard')
expect(stderr.output).to.include('Warning: Spend Alert. Each Heroku Standard')
expect(stderr.output).to.include('Private Space costs ~$1.39/hour (max $1000/month), pro-rated to the')
expect(stderr.output).to.include('second.')
})
Expand Down Expand Up @@ -164,7 +164,7 @@ describe('spaces:create', function () {

api.done()

expect(stderr.output).to.include('Warning: Spend Alert. During the limited GA period, each Heroku Shield')
expect(stderr.output).to.include('Warning: Spend Alert. Each Heroku Shield')
expect(stderr.output).to.include('Private Space costs ~$4.17/hour (max $3000/month), pro-rated to the')
expect(stderr.output).to.include('second.')
})
Expand Down
Loading