fix(spaces) remove "limited GA" phrasing #3106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friism
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
friism
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
|
Thank you for the PR on this. It looks like a couple more tests need to be updated, though. |
friism
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
friism
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
|
@k80bowman I did try to fix the other test too but I can only see that the assertion is failing but not what text it's getting for output. Should I set up local dev env? |
|
I set up local dev env but still unclear to me why the assertions are failing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's unclear to me if this phrasing is related to the limited GA of Private Space available to online pay-as-you go customers or if this has been there for 10 years since the beginning of Private Spaces. Regardless it's shown to Enterprise customers which doesn't make a lot of sense so I suggest removing it.
cc @gautam-rangarajan @vivekvj01