Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Prevent certain checks from running on forked PRs #16047

Open
wants to merge 27 commits into
base: develop
Choose a base branch
from
Open

ci: Prevent certain checks from running on forked PRs #16047

Show file tree
Hide file tree
Changes from 22 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
3a70aef
ci: Add fork repo check in workflows
andrewb1269hg Oct 18, 2024
e2a981d
Apply suggestions from code review - Nathan's Input
andrewb1269hg Oct 22, 2024
9eab51e
Move the fork check to the wider scope of the whole workflow.
andrewb1269hg Oct 22, 2024
0bdaa5c
Remove workflow_dispatch fork checks, move if-check above with stanza…
andrewb1269hg Oct 22, 2024
a26f2b0
Move if-checks, remove workflow_dispatch fork check, update spacing b…
andrewb1269hg Oct 22, 2024
bae8069
Move if-check to appropriate location.
andrewb1269hg Oct 22, 2024
4d7e032
Move if-checks, remove fork check, update job spacing.
andrewb1269hg Oct 22, 2024
d549910
Move if-check, remove fork repo check, update spacing.
andrewb1269hg Oct 22, 2024
7efc493
Move if-check, remove fork repo check, and update spacing.
andrewb1269hg Oct 22, 2024
f6220a9
Remove workflow_dispatch forked repo checks.
andrewb1269hg Oct 22, 2024
b69759c
Remove workflow_dispatch fork checks, reformat long lines of if checks.
andrewb1269hg Oct 22, 2024
4e7124e
Restore if checks back to before PR. Remove fork checks from workflow…
andrewb1269hg Oct 22, 2024
f765b52
Remove a missed fork check, move if check, update spacing.
andrewb1269hg Oct 22, 2024
26800e9
Remove fork checks.
andrewb1269hg Oct 22, 2024
9c9f226
Remove fork check, move if check, update spacing.
andrewb1269hg Oct 22, 2024
e7e4bbd
Remove additional workflow_dispatch fork request checks.
andrewb1269hg Oct 23, 2024
24b6a27
Clean up spacing and move if-checks.
andrewb1269hg Oct 23, 2024
ea48eb6
Remove final workflow_dispatch fork checks.
andrewb1269hg Oct 23, 2024
27e5c29
Add a check back that was mistakenly removed, remove 2 additional wor…
andrewb1269hg Oct 23, 2024
d1af980
Add fork repo check to workflow_call file.
andrewb1269hg Oct 23, 2024
a0a300e
Add fork checks to several workflow_call files.
andrewb1269hg Oct 23, 2024
bba297b
Add remaining workflow_call fork repo checks. Added such that the who…
andrewb1269hg Oct 23, 2024
72e158e
Merge remote-tracking branch 'origin/develop' into 16004-prevent-cert…
andrewb1269hg Oct 29, 2024
c14b80e
Update .github/workflows/flow-pull-request-formatting.yaml
andrewb1269hg Nov 5, 2024
768919c
Merge branch 'develop' into 16004-prevent-certain-checks-from-running…
andrewb1269hg Nov 26, 2024
2ea5ec4
Move the fork repo check to disable the whole build artifact job.
andrewb1269hg Nov 26, 2024
1346368
Additional changes per Nathan's review
andrewb1269hg Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/flow-pull-request-formatting.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ jobs:
title-check:
name: Title Check
runs-on: network-node-linux-medium
if: ${{ !github.event.pull_request.base.repo.fork }}
andrewb1269hg marked this conversation as resolved.
Show resolved Hide resolved
steps:
- name: Harden Runner
uses: step-security/harden-runner@f086349bfa2bd1361f7909c78558e816508cdc10 # v2.8.0
Expand Down
15 changes: 6 additions & 9 deletions .github/workflows/node-flow-fsts-daily-interval-01.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ jobs:
crypto-update-rhel7-4n-2c:
name: Crypto-Update-Rhel7-4N-2C
uses: ./.github/workflows/zxc-jrs-regression.yaml
if: ${{ !cancelled() && always() }}
with:
ref: ${{ github.event.inputs.ref }}
branch-name: ${{ github.event.inputs.branch-name }}
Expand All @@ -68,12 +69,11 @@ jobs:
gradle-cache-password: ${{ secrets.GRADLE_CACHE_PASSWORD }}
grafana-agent-username: ${{ secrets.GRAFANA_AGENT_USERNAME }}
grafana-agent-password: ${{ secrets.GRAFANA_AGENT_PASSWORD }}
if: ${{ !cancelled() && always() }}


crypto-update-rhel8-4n-2c:
name: Crypto-Update-Rhel8-4N-2C
uses: ./.github/workflows/zxc-jrs-regression.yaml
if: ${{ !cancelled() && always() }}
with:
ref: ${{ github.event.inputs.ref }}
branch-name: ${{ github.event.inputs.branch-name }}
Expand All @@ -91,12 +91,11 @@ jobs:
gradle-cache-password: ${{ secrets.GRADLE_CACHE_PASSWORD }}
grafana-agent-username: ${{ secrets.GRAFANA_AGENT_USERNAME }}
grafana-agent-password: ${{ secrets.GRAFANA_AGENT_PASSWORD }}
if: ${{ !cancelled() && always() }}


crypto-update-centos7-4n-2c:
name: Crypto-Update-CentOS7-4N-2C
uses: ./.github/workflows/zxc-jrs-regression.yaml
if: ${{ !cancelled() && always() }}
with:
ref: ${{ github.event.inputs.ref }}
branch-name: ${{ github.event.inputs.branch-name }}
Expand All @@ -114,12 +113,11 @@ jobs:
gradle-cache-password: ${{ secrets.GRADLE_CACHE_PASSWORD }}
grafana-agent-username: ${{ secrets.GRAFANA_AGENT_USERNAME }}
grafana-agent-password: ${{ secrets.GRAFANA_AGENT_PASSWORD }}
if: ${{ !cancelled() && always() }}


crypto-update-4n-2c:
name: Crypto-Update-4N-2C
uses: ./.github/workflows/zxc-jrs-regression.yaml
if: ${{ !cancelled() && always() }}
with:
ref: ${{ github.event.inputs.ref }}
branch-name: ${{ github.event.inputs.branch-name }}
Expand All @@ -137,11 +135,11 @@ jobs:
gradle-cache-password: ${{ secrets.GRADLE_CACHE_PASSWORD }}
grafana-agent-username: ${{ secrets.GRAFANA_AGENT_USERNAME }}
grafana-agent-password: ${{ secrets.GRAFANA_AGENT_PASSWORD }}
if: ${{ !cancelled() && always() }}

crypto-update-ubuntu2204-4n-2c:
name: Crypto-Update-Ubuntu2204-4N-2C
uses: ./.github/workflows/zxc-jrs-regression.yaml
if: ${{ !cancelled() && always() }}
with:
ref: ${{ github.event.inputs.ref }}
branch-name: ${{ github.event.inputs.branch-name }}
Expand All @@ -159,11 +157,11 @@ jobs:
gradle-cache-password: ${{ secrets.GRADLE_CACHE_PASSWORD }}
grafana-agent-username: ${{ secrets.GRAFANA_AGENT_USERNAME }}
grafana-agent-password: ${{ secrets.GRAFANA_AGENT_PASSWORD }}
if: ${{ !cancelled() && always() }}

crypto-update-removal-4n-2c:
name: Crypto-Update-Removal-4N-2C
uses: ./.github/workflows/zxc-jrs-regression.yaml
if: ${{ !cancelled() && always() }}
with:
ref: ${{ github.event.inputs.ref }}
branch-name: ${{ github.event.inputs.branch-name }}
Expand All @@ -181,4 +179,3 @@ jobs:
gradle-cache-password: ${{ secrets.GRADLE_CACHE_PASSWORD }}
grafana-agent-username: ${{ secrets.GRAFANA_AGENT_USERNAME }}
grafana-agent-password: ${{ secrets.GRAFANA_AGENT_PASSWORD }}
if: ${{ !cancelled() && always() }}
20 changes: 7 additions & 13 deletions .github/workflows/node-flow-fsts-daily-interval-02.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ jobs:
crypto-migration-7n-1c:
name: Crypto-Migration-7N-1C
uses: ./.github/workflows/zxc-jrs-regression.yaml
if: ${{ !cancelled() && always() }}
with:
ref: ${{ github.event.inputs.ref }}
branch-name: ${{ github.event.inputs.branch-name }}
Expand All @@ -77,12 +78,11 @@ jobs:
gradle-cache-password: ${{ secrets.GRADLE_CACHE_PASSWORD }}
grafana-agent-username: ${{ secrets.GRAFANA_AGENT_USERNAME }}
grafana-agent-password: ${{ secrets.GRAFANA_AGENT_PASSWORD }}
if: ${{ !cancelled() && always() }}


balances-validation-6n-1c:
name: Balances-Validation-6N-1C
uses: ./.github/workflows/zxc-jrs-regression.yaml
if: ${{ !cancelled() && always() }}
with:
ref: ${{ github.event.inputs.ref }}
branch-name: ${{ github.event.inputs.branch-name }}
Expand All @@ -102,12 +102,11 @@ jobs:
grafana-agent-password: ${{ secrets.GRAFANA_AGENT_PASSWORD }}
needs:
- crypto-migration-7n-1c
if: ${{ !cancelled() && always() }}


crypto-invalid-accounts-4n-4c:
name: Crypto-Invalid-Accounts-4N-4C
uses: ./.github/workflows/zxc-jrs-regression.yaml
if: ${{ !cancelled() && always() }}
with:
ref: ${{ github.event.inputs.ref }}
branch-name: ${{ github.event.inputs.branch-name }}
Expand All @@ -127,12 +126,11 @@ jobs:
grafana-agent-password: ${{ secrets.GRAFANA_AGENT_PASSWORD }}
needs:
- balances-validation-6n-1c
if: ${{ !cancelled() && always() }}


comp-nd-reconnect-correctness-6n-1c:
name: Comp-ND-Reconnect-Correctness-6N-1C
uses: ./.github/workflows/zxc-jrs-regression.yaml
if: ${{ !cancelled() && always() }}
with:
ref: ${{ github.event.inputs.ref }}
branch-name: ${{ github.event.inputs.branch-name }}
Expand All @@ -150,12 +148,11 @@ jobs:
gradle-cache-password: ${{ secrets.GRADLE_CACHE_PASSWORD }}
grafana-agent-username: ${{ secrets.GRAFANA_AGENT_USERNAME }}
grafana-agent-password: ${{ secrets.GRAFANA_AGENT_PASSWORD }}
if: ${{ !cancelled() && always() }}


reconnect-6n-4c:
name: Reconnect-6N-4C
uses: ./.github/workflows/zxc-jrs-regression.yaml
if: ${{ !cancelled() && always() }}
with:
ref: ${{ github.event.inputs.ref }}
branch-name: ${{ github.event.inputs.branch-name }}
Expand All @@ -175,12 +172,11 @@ jobs:
grafana-agent-password: ${{ secrets.GRAFANA_AGENT_PASSWORD }}
needs:
- comp-nd-reconnect-correctness-6n-1c
if: ${{ !cancelled() && always() }}


comp-neterror-4n-1c:
name: Comp-NetError-4N-1C
uses: ./.github/workflows/zxc-jrs-regression.yaml
if: ${{ !cancelled() && always() }}
with:
ref: ${{ github.event.inputs.ref }}
branch-name: ${{ github.event.inputs.branch-name }}
Expand All @@ -198,12 +194,11 @@ jobs:
gradle-cache-password: ${{ secrets.GRADLE_CACHE_PASSWORD }}
grafana-agent-username: ${{ secrets.GRAFANA_AGENT_USERNAME }}
grafana-agent-password: ${{ secrets.GRAFANA_AGENT_PASSWORD }}
if: ${{ !cancelled() && always() }}


crypto-restart-4n-1c:
name: Crypto-Restart-4N-1C
uses: ./.github/workflows/zxc-jrs-regression.yaml
if: ${{ !cancelled() && always() }}
with:
ref: ${{ github.event.inputs.ref }}
branch-name: ${{ github.event.inputs.branch-name }}
Expand All @@ -223,4 +218,3 @@ jobs:
grafana-agent-password: ${{ secrets.GRAFANA_AGENT_PASSWORD }}
needs:
- comp-neterror-4n-1c
if: ${{ !cancelled() && always() }}
14 changes: 5 additions & 9 deletions .github/workflows/node-flow-fsts-daily-interval-03.yaml
View file
Open in desktop
andrewb1269hg marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ jobs:
crypto-update-abort-4n-2c:
name: Crypto-Update-Abort-4N-2C
uses: ./.github/workflows/zxc-jrs-regression.yaml
if: ${{ !cancelled() && always() }}
with:
ref: ${{ github.event.inputs.ref }}
branch-name: ${{ github.event.inputs.branch-name }}
Expand All @@ -70,12 +71,11 @@ jobs:
gradle-cache-password: ${{ secrets.GRADLE_CACHE_PASSWORD }}
grafana-agent-username: ${{ secrets.GRAFANA_AGENT_USERNAME }}
grafana-agent-password: ${{ secrets.GRAFANA_AGENT_PASSWORD }}
if: ${{ !cancelled() && always() }}


comp-update-dispreupdate-4n-2c:
name: Comp-Update-DisPreUpdate-4N-2C
uses: ./.github/workflows/zxc-jrs-regression.yaml
if: ${{ !cancelled() && always() }}
with:
ref: ${{ github.event.inputs.ref }}
branch-name: ${{ github.event.inputs.branch-name }}
Expand All @@ -93,12 +93,11 @@ jobs:
gradle-cache-password: ${{ secrets.GRADLE_CACHE_PASSWORD }}
grafana-agent-username: ${{ secrets.GRAFANA_AGENT_USERNAME }}
grafana-agent-password: ${{ secrets.GRAFANA_AGENT_PASSWORD }}
if: ${{ !cancelled() && always() }}


comp-update-reconnect-4n-2c:
name: Comp-Update-Reconnect-4N-2C
uses: ./.github/workflows/zxc-jrs-regression.yaml
if: ${{ !cancelled() && always() }}
with:
ref: ${{ github.event.inputs.ref }}
branch-name: ${{ github.event.inputs.branch-name }}
Expand All @@ -116,12 +115,11 @@ jobs:
gradle-cache-password: ${{ secrets.GRADLE_CACHE_PASSWORD }}
grafana-agent-username: ${{ secrets.GRAFANA_AGENT_USERNAME }}
grafana-agent-password: ${{ secrets.GRAFANA_AGENT_PASSWORD }}
if: ${{ !cancelled() && always() }}


comp-update-reconnect-abort-4n-2c:
name: Comp-Update-Reconnect-Abort-4N-2C
uses: ./.github/workflows/zxc-jrs-regression.yaml
if: ${{ !cancelled() && always() }}
with:
ref: ${{ github.event.inputs.ref }}
branch-name: ${{ github.event.inputs.branch-name }}
Expand All @@ -139,12 +137,11 @@ jobs:
gradle-cache-password: ${{ secrets.GRADLE_CACHE_PASSWORD }}
grafana-agent-username: ${{ secrets.GRAFANA_AGENT_USERNAME }}
grafana-agent-password: ${{ secrets.GRAFANA_AGENT_PASSWORD }}
if: ${{ !cancelled() && always() }}


comp-update-reconnect-abort-dispreupdate-4n-2c:
name: Comp-Update-Reconnect-Abort-DisPreUpdate-4N-2C
uses: ./.github/workflows/zxc-jrs-regression.yaml
if: ${{ !cancelled() && always() }}
with:
ref: ${{ github.event.inputs.ref }}
branch-name: ${{ github.event.inputs.branch-name }}
Expand All @@ -162,4 +159,3 @@ jobs:
gradle-cache-password: ${{ secrets.GRADLE_CACHE_PASSWORD }}
grafana-agent-username: ${{ secrets.GRAFANA_AGENT_USERNAME }}
grafana-agent-password: ${{ secrets.GRAFANA_AGENT_PASSWORD }}
if: ${{ !cancelled() && always() }}
2 changes: 1 addition & 1 deletion .github/workflows/node-flow-fsts-daily-interval-04.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ jobs:
comp-3nreconnect-15n-4c:
name: Comp-3NReconnect-15N-4C
uses: ./.github/workflows/zxc-jrs-regression.yaml
if: ${{ !cancelled() && always() }}
with:
ref: ${{ github.event.inputs.ref }}
branch-name: ${{ github.event.inputs.branch-name }}
Expand All @@ -70,7 +71,6 @@ jobs:
gradle-cache-password: ${{ secrets.GRADLE_CACHE_PASSWORD }}
grafana-agent-username: ${{ secrets.GRAFANA_AGENT_USERNAME }}
grafana-agent-password: ${{ secrets.GRAFANA_AGENT_PASSWORD }}
if: ${{ !cancelled() && always() }}


# global-3nreconnect-15n-4c:
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/node-flow-fsts-daily-interval-05.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ jobs:
comp-reconnect-6n-1c:
name: Comp-Reconnect-6N-1C
uses: ./.github/workflows/zxc-jrs-regression.yaml
if: ${{ !cancelled() && always() }}
with:
ref: ${{ github.event.inputs.ref }}
branch-name: ${{ github.event.inputs.branch-name }}
Expand All @@ -67,8 +68,6 @@ jobs:
gradle-cache-password: ${{ secrets.GRADLE_CACHE_PASSWORD }}
grafana-agent-username: ${{ secrets.GRAFANA_AGENT_USERNAME }}
grafana-agent-password: ${{ secrets.GRAFANA_AGENT_PASSWORD }}
if: ${{ !cancelled() && always() }}


# comp-ni-reconnect-correctness-6n-1c:
# name: Comp-NI-Reconnect-Correctness-6N-1C
Expand Down
23 changes: 8 additions & 15 deletions .github/workflows/node-flow-fsts-daily-interval-06.yaml
View file
Open in desktop
andrewb1269hg marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ jobs:
minstake-4n:
name: MinStake-4N
uses: ./.github/workflows/zxc-jrs-regression.yaml
if: ${{ !cancelled() && always() }}
with:
ref: ${{ github.event.inputs.ref }}
branch-name: ${{ github.event.inputs.branch-name }}
Expand All @@ -76,12 +77,11 @@ jobs:
gradle-cache-password: ${{ secrets.GRADLE_CACHE_PASSWORD }}
grafana-agent-username: ${{ secrets.GRAFANA_AGENT_USERNAME }}
grafana-agent-password: ${{ secrets.GRAFANA_AGENT_PASSWORD }}
if: ${{ !cancelled() && always() }}


similarstake-4n:
name: SimilarStake-4N
uses: ./.github/workflows/zxc-jrs-regression.yaml
if: ${{ !cancelled() && always() }}
with:
ref: ${{ github.event.inputs.ref }}
branch-name: ${{ github.event.inputs.branch-name }}
Expand All @@ -101,12 +101,11 @@ jobs:
grafana-agent-password: ${{ secrets.GRAFANA_AGENT_PASSWORD }}
needs:
- minstake-4n
if: ${{ !cancelled() && always() }}


unevenstake-4n:
name: UnevenStake-4N
uses: ./.github/workflows/zxc-jrs-regression.yaml
if: ${{ !cancelled() && always() }}
with:
ref: ${{ github.event.inputs.ref }}
branch-name: ${{ github.event.inputs.branch-name }}
Expand All @@ -126,12 +125,11 @@ jobs:
grafana-agent-password: ${{ secrets.GRAFANA_AGENT_PASSWORD }}
needs:
- similarstake-4n
if: ${{ !cancelled() && always() }}


zerostake-4n:
name: ZeroStake-4N
uses: ./.github/workflows/zxc-jrs-regression.yaml
if: ${{ !cancelled() && always() }}
with:
ref: ${{ github.event.inputs.ref }}
branch-name: ${{ github.event.inputs.branch-name }}
Expand All @@ -151,12 +149,11 @@ jobs:
grafana-agent-password: ${{ secrets.GRAFANA_AGENT_PASSWORD }}
needs:
- unevenstake-4n
if: ${{ !cancelled() && always() }}


restartwithnewnodes-minstake-5n:
name: RestartWithNewNodes-MinStake-5N
uses: ./.github/workflows/zxc-jrs-regression.yaml
if: ${{ !cancelled() && always() }}
with:
ref: ${{ github.event.inputs.ref }}
branch-name: ${{ github.event.inputs.branch-name }}
Expand All @@ -174,12 +171,11 @@ jobs:
gradle-cache-password: ${{ secrets.GRADLE_CACHE_PASSWORD }}
grafana-agent-username: ${{ secrets.GRAFANA_AGENT_USERNAME }}
grafana-agent-password: ${{ secrets.GRAFANA_AGENT_PASSWORD }}
if: ${{ !cancelled() && always() }}


restartwithnewnodes-similarstake-5n:
name: RestartWithNewNodes-SimilarStake-5N
uses: ./.github/workflows/zxc-jrs-regression.yaml
if: ${{ !cancelled() && always() }}
with:
ref: ${{ github.event.inputs.ref }}
branch-name: ${{ github.event.inputs.branch-name }}
Expand All @@ -199,12 +195,11 @@ jobs:
grafana-agent-password: ${{ secrets.GRAFANA_AGENT_PASSWORD }}
needs:
- restartwithnewnodes-minstake-5n
if: ${{ !cancelled() && always() }}


restartwithnewnodes-unevenstake-5n:
name: RestartWithNewNodes-UnevenStake-5N
uses: ./.github/workflows/zxc-jrs-regression.yaml
if: ${{ !cancelled() && always() }}
with:
ref: ${{ github.event.inputs.ref }}
branch-name: ${{ github.event.inputs.branch-name }}
Expand All @@ -224,12 +219,11 @@ jobs:
grafana-agent-password: ${{ secrets.GRAFANA_AGENT_PASSWORD }}
needs:
- restartwithnewnodes-similarstake-5n
if: ${{ !cancelled() && always() }}


restartwithnewnodes-zerostake-5n:
name: RestartWithNewNodes-ZeroStake-5N
uses: ./.github/workflows/zxc-jrs-regression.yaml
if: ${{ !cancelled() && always() }}
with:
ref: ${{ github.event.inputs.ref }}
branch-name: ${{ github.event.inputs.branch-name }}
Expand All @@ -249,4 +243,3 @@ jobs:
grafana-agent-password: ${{ secrets.GRAFANA_AGENT_PASSWORD }}
needs:
- restartwithnewnodes-unevenstake-5n
if: ${{ !cancelled() && always() }}
Loading
Loading