fix(KFLUXBUGS-1278): make iib errors available to users #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
ShellCheck found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
johnbieren
force-pushed
the
kfluxbugs_1278
branch
2 times, most recently
from
f930352 to
dc9af67
Compare
|
all good code wise, but it has some shellcheck warnings to fix. EDIT: Actually some warning are a bit worrying - as for instance, commands unreacheable and so far. It might need a bit of tweaking. |
johnbieren
force-pushed
the
kfluxbugs_1278
branch
from
dc9af67 to
889a515
Compare
mmalina
reviewed
Sep 2, 2024
internal-services/catalog/iib-add-fbc-fragment-to-index-image-task.yaml
Outdated
Show resolved
Hide resolved
theflockers
previously approved these changes
Sep 2, 2024
mmalina
force-pushed
the
kfluxbugs_1278
branch
2 times, most recently
from
d648b10 to
ea4873e
Compare
johnbieren
force-pushed
the
kfluxbugs_1278
branch
from
ea4873e to
4ef6f55
Compare
mmalina
previously approved these changes
Sep 3, 2024
This commit exposes the iib error log if one occurred in the iib operation and bubbles it up to the pipelineRun as a result. It also changes the iib-add-fbc-fragment-to-index-image task to never fail. Signed-off-by: Johnny Bieren <[email protected]>
johnbieren
force-pushed
the
kfluxbugs_1278
branch
from
4ef6f55 to
5032e67
Compare
mmalina
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit exposes the iib error log if one occurred in the iib operation and bubbles it up to the pipelineRun as a result. It also changes the iib-add-fbc-fragment-to-index-image task to never fail.