Skip to content

Commit

Permalink
refactor(RELEASE-1024): update checkton version and allow it to fail
Browse files Browse the repository at this point in the history
Originally, our goal was to write a special
script to parse the sarif file and print a nice summary.

But since then, Adam improved the output of the checkton
action, so that it has all we need (including link to wiki
for each issue), so we can just use that.

Signed-off-by: Martin Malina <[email protected]>
  • Loading branch information
mmalina committed Sep 2, 2024
1 parent ea4873e commit d648b10
Showing 1 changed file with 6 additions and 13 deletions.
19 changes: 6 additions & 13 deletions .github/workflows/lint.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
yamllint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Run yamllint
uses: frenck/action-yamllint@v1
with:
Expand All @@ -20,13 +20,13 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: checkout files
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Install tkn cli
uses: jerop/[email protected]
with:
version: v${TKN_CLI_VERSION}
- name: Get changed files
uses: tj-actions/changed-files@v35
uses: tj-actions/changed-files@v41
id: changed-files
with:
files: |
Expand All @@ -42,7 +42,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Check out code
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
fetch-depth: 0
ref: ${{ github.event.pull_request.head.sha }}
Expand All @@ -60,14 +60,7 @@ jobs:
fetch-depth: 0
- name: Run Checkton
id: checkton
uses: chmeliik/checkton@v0.1.2 # Migrating to the konflux-ci org
uses: chmeliik/checkton@v0.2.2 # Migrating to the konflux-ci org
with:
# Let there be green. GitHub's code scanning will do the reporting.
fail-on-findings: false
fail-on-findings: true
find-copies-harder: true
- name: Upload SARIF File
uses: github/codeql-action/upload-sarif@v3
with:
sarif_file: ${{ steps.checkton.outputs.sarif }}
# Avoid clashing with ShellCheck
category: checkton

0 comments on commit d648b10

Please sign in to comment.