Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4187 use permission change command #4192

Merged
merged 4 commits into from
Jun 12, 2024

Conversation

VakarisZ
Copy link
Contributor

What does this PR do?

Issue #4187

Add any further explanations here.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Do all unit tests pass?
  • Do all end-to-end tests pass?
  • Any other testing performed?

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

@VakarisZ VakarisZ mentioned this pull request Jun 11, 2024
5 tasks
@mssalvatore mssalvatore force-pushed the 4187-use_permission_change_command branch from be0f85c to 960a76c Compare June 11, 2024 16:05
Copy link
Collaborator

@mssalvatore mssalvatore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does MSSQL also need fixing?

@VakarisZ
Copy link
Contributor Author

mssql only runs on windows

@@ -78,11 +79,17 @@ def _build_linux_hadoop_command(
download_url=agent_download_url,
)

chmod_options = LinuxSetPermissionsOptions(
agent_destination_path=agent_destination_path, permissions=0o700
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to not specify the default

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking that "Explicit is better than implicit".

@mssalvatore mssalvatore force-pushed the 4187-use_permission_change_command branch from 960a76c to 801a0e9 Compare June 12, 2024 13:11
@mssalvatore mssalvatore merged commit f962461 into develop Jun 12, 2024
1 check failed
@mssalvatore mssalvatore deleted the 4187-use_permission_change_command branch June 12, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants