-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4187 use permission change command #4192
Conversation
be0f85c
to
960a76c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does MSSQL also need fixing?
mssql only runs on windows |
@@ -78,11 +79,17 @@ def _build_linux_hadoop_command( | |||
download_url=agent_download_url, | |||
) | |||
|
|||
chmod_options = LinuxSetPermissionsOptions( | |||
agent_destination_path=agent_destination_path, permissions=0o700 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to not specify the default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking that "Explicit is better than implicit".
960a76c
to
801a0e9
Compare
What does this PR do?
Issue #4187
Add any further explanations here.
PR Checklist
Testing Checklist